Build the browser IRT shim with nacl-clang instead of biased bitcode.

Build the browser IRT shim with nacl-clang instead of biased bitcode.

This is one of the few remaining steps to removing biased bitcode (at
least for SFI NaCl).

Committed: https://crrev.com/862629a4bd59c32a7afa38ae204f8c44df184960
Cr-Commit-Position: refs/heads/master@{#374675}

[Derek Schuff, 2016-02-09 22:49:20]

dschuff@chromium.org changed reviewers:
+ dschuff@chromium.org

[Derek Schuff, 2016-02-09 22:49:20]

https://codereview.chromium.org/1681413002/diff/1/ppapi/native_client/src/unt...
File ppapi/native_client/src/untrusted/pnacl_irt_shim/pnacl_irt_shim.gyp
(right):

https://codereview.chromium.org/1681413002/diff/1/ppapi/native_client/src/unt...
ppapi/native_client/src/untrusted/pnacl_irt_shim/pnacl_irt_shim.gyp:31:
'pnacl_native_biased': 1,
we'll also need to convert this other target, but we can see if the other one
works first.

[Sam Clegg, 2016-02-09 22:53:12]

Hopefully patchset 2 should fix the failures.

[Derek Schuff, 2016-02-09 22:58:35]

https://codereview.chromium.org/1681413002/diff/40001/ppapi/native_client/src...
File ppapi/native_client/src/untrusted/pnacl_irt_shim/pnacl_irt_shim.gyp
(right):

https://codereview.chromium.org/1681413002/diff/40001/ppapi/native_client/src...
ppapi/native_client/src/untrusted/pnacl_irt_shim/pnacl_irt_shim.gyp:31:
'pnacl_native_biased': 1,
This target is just used by the SDK, right?

[Sam Clegg, 2016-02-09 23:05:38]

On 2016/02/09 22:58:35, Derek Schuff wrote:
>
https://codereview.chromium.org/1681413002/diff/40001/ppapi/native_client/src...
> File ppapi/native_client/src/untrusted/pnacl_irt_shim/pnacl_irt_shim.gyp
> (right):
> 
>
https://codereview.chromium.org/1681413002/diff/40001/ppapi/native_client/src...
> ppapi/native_client/src/untrusted/pnacl_irt_shim/pnacl_irt_shim.gyp:31:
> 'pnacl_native_biased': 1,
> This target is just used by the SDK, right?

Yes, it looks like it.   In which case does it need to support non-sfi?

[Sam Clegg, 2016-02-09 23:33:27]

What do you think of this version of the change?  Seems like its gonna pass the
bots.

[Sam Clegg, 2016-02-09 23:55:49]

The CQ bit was checked by sbc@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-02-09 23:56:51]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1681413002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1681413002/40001

[Derek Schuff, 2016-02-10 00:20:06]

lgtm

[commit-bot: I haz the power, 2016-02-10 00:58:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-10 00:58:35]

Dry run: This issue passed the CQ dry run.

[Sam Clegg, 2016-02-10 01:39:41]

The CQ bit was checked by sbc@chromium.org

[commit-bot: I haz the power, 2016-02-10 01:43:15]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1681413002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1681413002/40001

[commit-bot: I haz the power, 2016-02-10 01:58:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-10 01:58:10]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Sam Clegg, 2016-02-10 01:59:30]

sbc@chromium.org changed reviewers:
+ bradnelson@chromium.org

[Sam Clegg, 2016-02-10 01:59:31]

+bradnelson for OWNERS

[bradnelson, 2016-02-10 17:16:04]

The CQ bit was checked by bradnelson@chromium.org

[bradnelson, 2016-02-10 17:16:04]

lgtm

[commit-bot: I haz the power, 2016-02-10 17:18:15]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1681413002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1681413002/40001

[commit-bot: I haz the power, 2016-02-10 17:24:50]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-02-10 17:26:09]

Description was changed from

==========
Build the browser IRT shim with nacl-clang instead of biased bitcode.

This is one of the few remaining steps to removing biased bitcode (at
least for SFI NaCl).
==========

to

==========
Build the browser IRT shim with nacl-clang instead of biased bitcode.

This is one of the few remaining steps to removing biased bitcode (at
least for SFI NaCl).

Committed: https://crrev.com/862629a4bd59c32a7afa38ae204f8c44df184960
Cr-Commit-Position: refs/heads/master@{#374675}
==========

[commit-bot: I haz the power, 2016-02-10 17:26:10]

Patchset 3 (id:??) landed as
https://crrev.com/862629a4bd59c32a7afa38ae204f8c44df184960
Cr-Commit-Position: refs/heads/master@{#374675}