Issue 1681293005: Fix JS-intrinsic definition of SDK classes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1681293005: Fix JS-intrinsic definition of SDK classes (Closed)

Created:
4 years, 10 months ago by ochafik

Modified:
4 years, 10 months ago

Reviewers:
Jennifer Messerly

CC:
dev-compiler+reviews_dartlang.org

Base URL:
git@github.com:dart-lang/dev_compiler.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Created: 4 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+23 lines, -20 lines)			Patch
	M	lib/runtime/dart/_runtime.js	View		8 chunks	+20 lines, -20 lines	0 comments	Download
	M	lib/src/codegen/js_codegen.dart	View		1 chunk	+3 lines, -0 lines	0 comments	Download

Total messages: 5 (2 generated)

ochafik

Hey John, here's some tiny eye-candy that actually came up while evaluating github.com/rollup/rollup/.

4 years, 10 months ago (2016-02-10 23:47:13 UTC) #2

ochafik

4 years, 10 months ago (2016-02-11 17:31:41 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
11b03b5417f2fe9153b72e3317ed7dc82354f647 (presubmit successful).