lib/src/codegen/js_codegen.dart - Issue 1681293005: Fix JS-intrinsic definition of SDK classes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: lib/src/codegen/js_codegen.dart

Issue 1681293005: Fix JS-intrinsic definition of SDK classes (Closed) Base URL: git@github.com:dart-lang/dev_compiler.git@master

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: lib/src/codegen/js_codegen.dart

diff --git a/lib/src/codegen/js_codegen.dart b/lib/src/codegen/js_codegen.dart

index 005808114b65eefe3e35961473b15a75dcb16424..2a8e4b61c52c3f30494d95e721f4f91a102aa44f 100644

--- a/lib/src/codegen/js_codegen.dart

+++ b/lib/src/codegen/js_codegen.dart

@@ -2399,6 +2399,9 @@ class JSCodegenVisitor extends GeneralizingAstVisitor

if (isPublic(fieldName)) _addExport(fieldName, exportName);

var declKeyword = field.isConst || field.isFinal ? 'const' : 'let';

+ if (isJSTopLevel && jsInit is JS.ClassExpression) {

+ return new JS.ClassDeclaration(jsInit);

+ }

return js.statement('#;', [

annotate(

new JS.VariableDeclarationList(declKeyword, [

« no previous file with comments | « lib/runtime/dart/_runtime.js ('k') | no next file » | no next file with comments »