third_party/WebKit/Source/core/frame/UseCounter.cpp - Issue 1681273003: Add CSS parser support for break-after, break-before and break-inside.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/frame/UseCounter.cpp

Issue 1681273003: Add CSS parser support for break-after, break-before and break-inside. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Update some text expectations, and move the new properties into ComputedStyle, since they aren't ra… Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/css/CSSValueKeywords.in ('K') | « third_party/WebKit/Source/core/editing/EditingStyle.cpp ('k') | third_party/WebKit/Source/core/layout/LayoutBox.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/frame/UseCounter.cpp

diff --git a/third_party/WebKit/Source/core/frame/UseCounter.cpp b/third_party/WebKit/Source/core/frame/UseCounter.cpp

index 86e31a896f286933128bca991381e9970a96d07f..70f4dbc25ae61c3716d521584c400fdb2e07c67d 100644

--- a/third_party/WebKit/Source/core/frame/UseCounter.cpp

+++ b/third_party/WebKit/Source/core/frame/UseCounter.cpp

@@ -550,6 +550,9 @@ int UseCounter::mapCSSPropertyIdToCSSSampleIdForHistogram(int id)

case CSSPropertyFontDisplay: return 516;

case CSSPropertyContain: return 517;

case CSSPropertyD: return 518;

+ case CSSPropertyBreakAfter: return 519;

+ case CSSPropertyBreakBefore: return 520;

+ case CSSPropertyBreakInside: return 521;

// 1. Add new features above this line (don't change the assigned numbers of the existing

// items).

@@ -566,7 +569,7 @@ int UseCounter::mapCSSPropertyIdToCSSSampleIdForHistogram(int id)

return 0;

}

-static int maximumCSSSampleId() { return 518; }

+static int maximumCSSSampleId() { return 521; }

static EnumerationHistogram& featureObserverHistogram()

{