Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Side by Side Diff: third_party/WebKit/Source/core/frame/UseCounter.cpp

Issue 1681273003: Add CSS parser support for break-after, break-before and break-inside. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Update some text expectations, and move the new properties into ComputedStyle, since they aren't ra… Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2012 Google, Inc. All rights reserved. 2 * Copyright (C) 2012 Google, Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 532 matching lines...) Expand 10 before | Expand all | Expand 10 after
543 case CSSPropertyTextCombineUpright: return 509; 543 case CSSPropertyTextCombineUpright: return 509;
544 case CSSPropertyTextOrientation: return 510; 544 case CSSPropertyTextOrientation: return 510;
545 case CSSPropertyGridColumnGap: return 511; 545 case CSSPropertyGridColumnGap: return 511;
546 case CSSPropertyGridRowGap: return 512; 546 case CSSPropertyGridRowGap: return 512;
547 case CSSPropertyGridGap: return 513; 547 case CSSPropertyGridGap: return 513;
548 case CSSPropertyFontFeatureSettings: return 514; 548 case CSSPropertyFontFeatureSettings: return 514;
549 case CSSPropertyVariable: return 515; 549 case CSSPropertyVariable: return 515;
550 case CSSPropertyFontDisplay: return 516; 550 case CSSPropertyFontDisplay: return 516;
551 case CSSPropertyContain: return 517; 551 case CSSPropertyContain: return 517;
552 case CSSPropertyD: return 518; 552 case CSSPropertyD: return 518;
553 case CSSPropertyBreakAfter: return 519;
554 case CSSPropertyBreakBefore: return 520;
555 case CSSPropertyBreakInside: return 521;
553 556
554 // 1. Add new features above this line (don't change the assigned numbers of the existing 557 // 1. Add new features above this line (don't change the assigned numbers of the existing
555 // items). 558 // items).
556 // 2. Update maximumCSSSampleId() with the new maximum value. 559 // 2. Update maximumCSSSampleId() with the new maximum value.
557 // 3. Run the update_use_counter_css.py script in 560 // 3. Run the update_use_counter_css.py script in
558 // chromium/src/tools/metrics/histograms to update the UMA histogram names. 561 // chromium/src/tools/metrics/histograms to update the UMA histogram names.
559 562
560 case CSSPropertyInvalid: 563 case CSSPropertyInvalid:
561 ASSERT_NOT_REACHED(); 564 ASSERT_NOT_REACHED();
562 return 0; 565 return 0;
563 } 566 }
564 567
565 ASSERT_NOT_REACHED(); 568 ASSERT_NOT_REACHED();
566 return 0; 569 return 0;
567 } 570 }
568 571
569 static int maximumCSSSampleId() { return 518; } 572 static int maximumCSSSampleId() { return 521; }
570 573
571 static EnumerationHistogram& featureObserverHistogram() 574 static EnumerationHistogram& featureObserverHistogram()
572 { 575 {
573 DEFINE_STATIC_LOCAL(EnumerationHistogram, histogram, ("WebCore.FeatureObserv er", UseCounter::NumberOfFeatures)); 576 DEFINE_STATIC_LOCAL(EnumerationHistogram, histogram, ("WebCore.FeatureObserv er", UseCounter::NumberOfFeatures));
574 return histogram; 577 return histogram;
575 } 578 }
576 579
577 void UseCounter::muteForInspector() 580 void UseCounter::muteForInspector()
578 { 581 {
579 UseCounter::m_muteCount++; 582 UseCounter::m_muteCount++;
(...skipping 454 matching lines...) Expand 10 before | Expand all | Expand 10 after
1034 UseCounter* UseCounter::getFrom(const StyleSheetContents* sheetContents) 1037 UseCounter* UseCounter::getFrom(const StyleSheetContents* sheetContents)
1035 { 1038 {
1036 // FIXME: We may want to handle stylesheets that have multiple owners 1039 // FIXME: We may want to handle stylesheets that have multiple owners
1037 // https://crbug.com/242125 1040 // https://crbug.com/242125
1038 if (sheetContents && sheetContents->hasSingleOwnerNode()) 1041 if (sheetContents && sheetContents->hasSingleOwnerNode())
1039 return getFrom(sheetContents->singleOwnerDocument()); 1042 return getFrom(sheetContents->singleOwnerDocument());
1040 return 0; 1043 return 0;
1041 } 1044 }
1042 1045
1043 } // namespace blink 1046 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698