chrome/common/chrome_features.cc - Issue 1681263003: metrics: Add leak detector controller in Chrome OS metrics system

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/chrome_features.cc

Issue 1681263003: metrics: Add leak detector controller in Chrome OS metrics system (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: "Addressed asvitkine's comments: remove using statement, move runtime flag to chrome_features" Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/common/chrome_features.cc

diff --git a/chrome/common/chrome_features.cc b/chrome/common/chrome_features.cc

index b571587be63827821488e5123875a7a0127a5a6a..0739647808f0945ddfcc5bd0dc975cfdfa8a0d37 100644

--- a/chrome/common/chrome_features.cc

+++ b/chrome/common/chrome_features.cc

@@ -22,4 +22,12 @@ const base::Feature kLinuxObsoleteSystemIsEndOfTheLine{

"LinuxObsoleteSystemIsEndOfTheLine", base::FEATURE_DISABLED_BY_DEFAULT};

#endif

+#if defined(OS_CHROMEOS)

+// Runtime flag that indicates whether this leak detector should be enabled in

+// the current instance of Chrome.

+const base::Feature kEnableRuntimeMemoryLeakDetector {

+ "EnableRuntimeMemoryLeakDetector", base::FEATURE_DISABLED_BY_DEFAULT};

Alexei Svitkine (slow) 2016/02/23 16:56:53 Nit: No "Enable" in the name or variable name, ple

Simon Que 2016/02/23 18:43:23 Done.

+#endif // defined(OS_CHROMEOS)

} // namespace features

« chrome/browser/metrics/chromeos_metrics_provider.cc ('K') | « chrome/common/chrome_features.h ('k') | components/components_tests.gyp » ('j') | no next file with comments »