Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(217)

Unified Diff: chrome/browser/metrics/chromeos_metrics_provider.cc

Issue 1681263003: metrics: Add leak detector controller in Chrome OS metrics system (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: "Addressed asvitkine's comments: remove using statement, move runtime flag to chrome_features" Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/metrics/chromeos_metrics_provider.cc
diff --git a/chrome/browser/metrics/chromeos_metrics_provider.cc b/chrome/browser/metrics/chromeos_metrics_provider.cc
index fae556025bb6d18a8e6044cdd4854ee3d803b3da..cca91bfcda14ae9aa2fe606dfeb9f7af60fa9e55 100644
--- a/chrome/browser/metrics/chromeos_metrics_provider.cc
+++ b/chrome/browser/metrics/chromeos_metrics_provider.cc
@@ -6,13 +6,16 @@
#include <stddef.h>
+#include "base/feature_list.h"
#include "base/strings/string_number_conversions.h"
#include "base/strings/string_util.h"
#include "base/strings/utf_string_conversions.h"
#include "chrome/browser/browser_process.h"
#include "chrome/browser/chromeos/policy/browser_policy_connector_chromeos.h"
+#include "chrome/common/chrome_features.h"
#include "chrome/common/pref_names.h"
#include "chromeos/system/statistics_provider.h"
+#include "components/metrics/leak_detector/leak_detector.h"
#include "components/metrics/metrics_service.h"
#include "components/metrics/proto/chrome_user_metrics_extension.pb.h"
#include "components/prefs/pref_registry_simple.h"
@@ -141,6 +144,11 @@ ChromeOSMetricsProvider::GetEnrollmentStatus() {
void ChromeOSMetricsProvider::Init() {
perf_provider_.Init();
+
+ if (base::FeatureList::IsEnabled(
+ features::kEnableRuntimeMemoryLeakDetector)) {
Alexei Svitkine (slow) 2016/02/23 16:56:53 Nit: No need for "Enable" in the feature variable
Simon Que 2016/02/23 18:43:23 Done.
+ leak_detector_controller_.reset(new metrics::LeakDetectorController);
+ }
}
void ChromeOSMetricsProvider::OnDidCreateMetricsLog() {

Powered by Google App Engine
This is Rietveld 408576698