Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(290)

Issue 1681143002: Reland of Add --output-directory to stack tool buildbot step (Closed)

Created:
4 years, 10 months ago by agrieve
Modified:
4 years, 10 months ago
Reviewers:
flackr, jbudorick
CC:
chromium-reviews, jbudorick+watch_chromium.org, mikecase+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland of Add --output-directory to stack tool buildbot step (patchset #1 id:1 of https://codereview.chromium.org/1677193002/ ) TBR=jbudorick@chromium.org,flackr@chromium.org BUG=573345 Committed: https://crrev.com/a952a118dc8975ec13c893cd1a620130f1a6c3ea Cr-Commit-Position: refs/heads/master@{#374419}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M build/android/buildbot/bb_device_steps.py View 1 1 chunk +4 lines, -1 line 0 comments Download

Depends on Patchset:

Messages

Total messages: 11 (4 generated)
agrieve
Created Reland of Add --output-directory to stack tool buildbot step
4 years, 10 months ago (2016-02-09 16:29:44 UTC) #1
agrieve
On 2016/02/09 16:29:44, agrieve wrote: > Created Reland of Add --output-directory to stack tool buildbot ...
4 years, 10 months ago (2016-02-09 16:34:38 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1681143002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1681143002/40001
4 years, 10 months ago (2016-02-09 16:35:57 UTC) #5
flackr
lgtm
4 years, 10 months ago (2016-02-09 16:43:23 UTC) #6
jbudorick
lgtm the argument parsing logic in stack is terrible :(
4 years, 10 months ago (2016-02-09 16:44:17 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:40001)
4 years, 10 months ago (2016-02-09 18:29:53 UTC) #9
commit-bot: I haz the power
4 years, 10 months ago (2016-02-09 18:31:22 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/a952a118dc8975ec13c893cd1a620130f1a6c3ea
Cr-Commit-Position: refs/heads/master@{#374419}

Powered by Google App Engine
This is Rietveld 408576698