Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(340)

Unified Diff: build/android/buildbot/bb_device_steps.py

Issue 1681143002: Reland of Add --output-directory to stack tool buildbot step (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/android/buildbot/bb_device_steps.py
diff --git a/build/android/buildbot/bb_device_steps.py b/build/android/buildbot/bb_device_steps.py
index f52c24b9cf88789a33a1726af6c172eb03a6133a..5d8731f26e7b2db20a28b9f950dab34c2aa3acd6 100755
--- a/build/android/buildbot/bb_device_steps.py
+++ b/build/android/buildbot/bb_device_steps.py
@@ -630,14 +630,17 @@ def RunStackToolSteps(options):
Stack tool is run for logcat dump, optionally for ASAN.
"""
bb_annotations.PrintNamedStep('Run stack tool with logcat dump')
- logcat_file = os.path.join(CHROME_OUT_DIR, options.target, 'full_log.txt')
+ build_dir = os.path.join(CHROME_OUT_DIR, options.target)
+ logcat_file = os.path.join(build_dir, 'full_log.txt')
RunCmd([os.path.join(CHROME_SRC_DIR, 'third_party', 'android_platform',
'development', 'scripts', 'stack'),
+ '--output-directory', build_dir,
'--more-info', logcat_file])
if options.asan_symbolize:
bb_annotations.PrintNamedStep('Run stack tool for ASAN')
RunCmd([
os.path.join(CHROME_SRC_DIR, 'build', 'android', 'asan_symbolize.py'),
+ '--output-directory', build_dir,
'-l', logcat_file])
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698