Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(354)

Issue 1681123002: Plumb Notification action icons through to the UI layer. (Closed)

Created:
4 years, 10 months ago by Michael van Ouwerkerk
Modified:
4 years, 10 months ago
Reviewers:
Peter Beverloo
CC:
chromium-reviews, Peter Beverloo, mlamouri+watch-notifications_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@ActionIconResourceFetching
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Plumb Notification action icons through to the UI layer. * This makes the feature functional on both Desktop and Android. * It is still behind the NotificationActionIcons runtime flag. * Stops using NotificationCompat to enable using the Icon class. BUG=581336 Committed: https://crrev.com/647546723325fa08774caf23c1aa71dc15b279c1 Cr-Commit-Position: refs/heads/master@{#374918}

Patch Set 1 #

Patch Set 2 : Fix tests. #

Patch Set 3 : #

Patch Set 4 : Rebase. Appease FindBugs. #

Patch Set 5 : Rebase. Appease FindBugs some more. #

Total comments: 16

Patch Set 6 : Address peter's comments. #

Total comments: 4

Patch Set 7 : Tweak todos. #

Patch Set 8 : Add notes. #

Patch Set 9 : Fix bad merge. #

Patch Set 10 : Delete unused addAction overload. #

Patch Set 11 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+202 lines, -94 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/notifications/CustomNotificationBuilder.java View 1 2 3 4 5 6 7 7 chunks +43 lines, -21 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationBuilderBase.java View 1 2 3 4 5 6 7 8 9 6 chunks +47 lines, -10 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationUIManager.java View 1 2 3 4 5 6 3 chunks +10 lines, -5 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/notifications/StandardNotificationBuilder.java View 1 2 3 4 5 6 7 3 chunks +7 lines, -9 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/notifications/CustomNotificationBuilderTest.java View 1 2 3 4 5 6 7 8 9 3 chunks +29 lines, -28 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/notifications/StandardNotificationBuilderTest.java View 1 2 3 4 5 6 7 8 9 10 3 chunks +9 lines, -4 lines 0 comments Download
M chrome/browser/notifications/notification_ui_manager_android.cc View 1 2 3 4 5 6 7 8 6 chunks +38 lines, -7 lines 0 comments Download
M chrome/browser/notifications/platform_notification_service_impl.cc View 1 2 3 4 5 6 3 chunks +15 lines, -9 lines 0 comments Download
M chrome/browser/notifications/platform_notification_service_unittest.cc View 1 1 chunk +4 lines, -1 line 0 comments Download

Depends on Patchset:

Messages

Total messages: 29 (15 generated)
Michael van Ouwerkerk
Peter, could you take a look please?
4 years, 10 months ago (2016-02-09 15:56:49 UTC) #3
Peter Beverloo
https://codereview.chromium.org/1681123002/diff/80001/chrome/android/java/src/org/chromium/chrome/browser/notifications/CustomNotificationBuilder.java File chrome/android/java/src/org/chromium/chrome/browser/notifications/CustomNotificationBuilder.java (right): https://codereview.chromium.org/1681123002/diff/80001/chrome/android/java/src/org/chromium/chrome/browser/notifications/CustomNotificationBuilder.java#newcode35 chrome/android/java/src/org/chromium/chrome/browser/notifications/CustomNotificationBuilder.java:35: private static final int MAX_ACTION_ICON_WIDTH_DP = 32; Looking at ...
4 years, 10 months ago (2016-02-10 12:29:37 UTC) #4
Michael van Ouwerkerk
Thanks Peter. Please take another look. https://codereview.chromium.org/1681123002/diff/80001/chrome/android/java/src/org/chromium/chrome/browser/notifications/CustomNotificationBuilder.java File chrome/android/java/src/org/chromium/chrome/browser/notifications/CustomNotificationBuilder.java (right): https://codereview.chromium.org/1681123002/diff/80001/chrome/android/java/src/org/chromium/chrome/browser/notifications/CustomNotificationBuilder.java#newcode35 chrome/android/java/src/org/chromium/chrome/browser/notifications/CustomNotificationBuilder.java:35: private static final ...
4 years, 10 months ago (2016-02-10 17:18:12 UTC) #5
Peter Beverloo
lgtm https://codereview.chromium.org/1681123002/diff/80001/chrome/android/java/src/org/chromium/chrome/browser/notifications/StandardNotificationBuilder.java File chrome/android/java/src/org/chromium/chrome/browser/notifications/StandardNotificationBuilder.java (right): https://codereview.chromium.org/1681123002/diff/80001/chrome/android/java/src/org/chromium/chrome/browser/notifications/StandardNotificationBuilder.java#newcode22 chrome/android/java/src/org/chromium/chrome/browser/notifications/StandardNotificationBuilder.java:22: Notification.Builder builder = new Notification.Builder(mContext); On 2016/02/10 17:18:12, ...
4 years, 10 months ago (2016-02-10 18:05:01 UTC) #6
Michael van Ouwerkerk
Thanks Peter. https://codereview.chromium.org/1681123002/diff/80001/chrome/android/java/src/org/chromium/chrome/browser/notifications/StandardNotificationBuilder.java File chrome/android/java/src/org/chromium/chrome/browser/notifications/StandardNotificationBuilder.java (right): https://codereview.chromium.org/1681123002/diff/80001/chrome/android/java/src/org/chromium/chrome/browser/notifications/StandardNotificationBuilder.java#newcode22 chrome/android/java/src/org/chromium/chrome/browser/notifications/StandardNotificationBuilder.java:22: Notification.Builder builder = new Notification.Builder(mContext); On 2016/02/10 ...
4 years, 10 months ago (2016-02-11 11:02:03 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1681123002/140001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1681123002/140001
4 years, 10 months ago (2016-02-11 11:02:16 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: android_chromium_gn_compile_rel on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_chromium_gn_compile_rel/builds/20725)
4 years, 10 months ago (2016-02-11 11:21:36 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: android_chromium_gn_compile_rel on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_chromium_gn_compile_rel/builds/20725) android_compile_dbg on tryserver.chromium.android (JOB_FAILED, ...
4 years, 10 months ago (2016-02-11 11:21:53 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1681123002/160001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1681123002/160001
4 years, 10 months ago (2016-02-11 11:37:36 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/21901)
4 years, 10 months ago (2016-02-11 13:37:34 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1681123002/180001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1681123002/180001
4 years, 10 months ago (2016-02-11 17:17:44 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1681123002/200001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1681123002/200001
4 years, 10 months ago (2016-02-11 18:06:57 UTC) #25
commit-bot: I haz the power
Committed patchset #11 (id:200001)
4 years, 10 months ago (2016-02-11 19:27:41 UTC) #27
commit-bot: I haz the power
4 years, 10 months ago (2016-02-16 22:36:06 UTC) #29
Message was sent while issue was closed.
Patchset 11 (id:??) landed as
https://crrev.com/647546723325fa08774caf23c1aa71dc15b279c1
Cr-Commit-Position: refs/heads/master@{#374918}

Powered by Google App Engine
This is Rietveld 408576698