Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(535)

Issue 1681033003: Remove Mandoline FYI upload step and perf testing (Closed)

Created:
4 years, 10 months ago by msw
Modified:
4 years, 10 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org, sky, yzshen1
Base URL:
https://chromium.googlesource.com/chromium/tools/build.git@master
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

Remove Mandoline FYI upload step and perf testing We are removing unused experimental Mandoline code: https://codereview.chromium.org/1677293002/ The chromium-mojo FYI waterfall no longer needs to: - Upload Mandoline binaries to gs://mandoline - Run performance testing of Mandoline - Run html_viewer_unittests - Build mandoline:all (use mojo:tests and mojo_apptests) Waterfall: https://build.chromium.org/p/chromium.mojo/console Also remove the (now) unused gsutil ls api. TODO: Remove perf bots from waterfall. TODO: Don't run unittests that already run on main/CQ. BUG=541265, 585289, 585610 R=dpranke@chromium.org TEST=Waterfall still runs some Mojo unittests and apptests. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=298687

Patch Set 1 #

Patch Set 2 : Also remove perf testing code. #

Patch Set 3 : Also remove html_viewer_unittests step. #

Patch Set 4 : Add mojo:tests compile target. #

Messages

Total messages: 13 (9 generated)
msw
Hey Dirk, please take a look; thanks!
4 years, 10 months ago (2016-02-09 20:16:22 UTC) #1
Dirk Pranke
lgtm
4 years, 10 months ago (2016-02-09 22:51:01 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1681033003/50001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1681033003/50001
4 years, 10 months ago (2016-02-09 22:52:17 UTC) #11
commit-bot: I haz the power
4 years, 10 months ago (2016-02-09 22:55:15 UTC) #13
Message was sent while issue was closed.
Committed patchset #4 (id:50001) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=298687

Powered by Google App Engine
This is Rietveld 408576698