Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1176)

Issue 1681013004: Make object-sizing-zero-intrinsic-width-height a javascript test (Closed)

Created:
4 years, 10 months ago by davve
Modified:
4 years, 10 months ago
Reviewers:
fs
CC:
blink-reviews, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make object-sizing-zero-intrinsic-width-height a javascript test A javascript test can detect failures at a more fine-grained level and is potentially less performance intensive. BUG=585467 Committed: https://crrev.com/90886341815d1643698f147538c6b59bf761383f Cr-Commit-Position: refs/heads/master@{#374408}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -26 lines) Patch
M third_party/WebKit/LayoutTests/svg/custom/object-sizing-zero-intrinsic-width-height.html View 1 chunk +25 lines, -25 lines 0 comments Download
D third_party/WebKit/LayoutTests/svg/custom/object-sizing-zero-intrinsic-width-height-expected.html View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
davve
4 years, 10 months ago (2016-02-09 16:58:56 UTC) #2
fs
lgtm
4 years, 10 months ago (2016-02-09 17:04:14 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1681013004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1681013004/1
4 years, 10 months ago (2016-02-09 17:09:02 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-09 17:55:14 UTC) #6
commit-bot: I haz the power
4 years, 10 months ago (2016-02-09 17:56:14 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/90886341815d1643698f147538c6b59bf761383f
Cr-Commit-Position: refs/heads/master@{#374408}

Powered by Google App Engine
This is Rietveld 408576698