Removed/Replaced uses of deprecated NSURLConnection methods.

Removed/Replaced uses of deprecated NSURLConnection methods.

BUG=571217
Committed: https://crrev.com/e6dc703f48f889f67863d7bd1b6a5b9f761a132b
Cr-Commit-Position: refs/heads/master@{#374671}

[pkl (ping after 24h if needed), 2016-02-08 22:46:24]

pkl@chromium.org changed reviewers:
+ cbentzel@chromium.org, ellyjones@chromium.org

[pkl (ping after 24h if needed), 2016-02-08 22:46:25]

I changed one of the two affected tests to use NSURLSession.
The other one appears to want to use NSURLConnection by
design, so I #if0 it out so we can pass compilation.

[pkl (ping after 24h if needed), 2016-02-09 21:44:13]

pkl@chromium.org changed reviewers:
+ mef@chromium.org
- ellyjones@chromium.org

[pkl (ping after 24h if needed), 2016-02-09 21:44:14]

https://codereview.chromium.org/1680913002/diff/20001/ios/crnet/test/crnet_ht...
File ios/crnet/test/crnet_http_tests.mm (left):

https://codereview.chromium.org/1680913002/diff/20001/ios/crnet/test/crnet_ht...
ios/crnet/test/crnet_http_tests.mm:208: error:nullptr];
Note: +sendSynchronousRequest:returningResponse:error: has been deprecated
starting with iOS9. Since Chrome iOS is now iOS 9 only, this deprecated method
can no longer be used. I'm removing this test because the next test
NSURLSessionReceivesData is already testing the code path for NSURLSession.

[Elly Fong-Jones, 2016-02-10 13:44:12]

ellyjones@chromium.org changed reviewers:
+ ellyjones@chromium.org

[Elly Fong-Jones, 2016-02-10 13:44:12]

lgtm

https://codereview.chromium.org/1680913002/diff/20001/ios/crnet/test/crnet_ht...
File ios/crnet/test/crnet_http_tests.mm (left):

https://codereview.chromium.org/1680913002/diff/20001/ios/crnet/test/crnet_ht...
ios/crnet/test/crnet_http_tests.mm:208: error:nullptr];
On 2016/02/09 21:44:14, pklpkl wrote:
> Note: +sendSynchronousRequest:returningResponse:error: has been deprecated
> starting with iOS9. Since Chrome iOS is now iOS 9 only, this deprecated method
> can no longer be used. I'm removing this test because the next test
> NSURLSessionReceivesData is already testing the code path for NSURLSession.

You are probably fine to delete these tests, if you only need iOS 9.0+ coverage.

[mef, 2016-02-10 16:20:04]

lgtm

[pkl (ping after 24h if needed), 2016-02-10 16:25:34]

The CQ bit was checked by pkl@chromium.org

[commit-bot: I haz the power, 2016-02-10 16:26:41]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1680913002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1680913002/20001

[commit-bot: I haz the power, 2016-02-10 16:58:54]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-02-10 16:59:58]

Description was changed from

==========
Removed/Replaced uses of deprecated NSURLConnection methods.

BUG=571217
==========

to

==========
Removed/Replaced uses of deprecated NSURLConnection methods.

BUG=571217

Committed: https://crrev.com/e6dc703f48f889f67863d7bd1b6a5b9f761a132b
Cr-Commit-Position: refs/heads/master@{#374671}
==========

[commit-bot: I haz the power, 2016-02-10 16:59:59]

Patchset 2 (id:??) landed as
https://crrev.com/e6dc703f48f889f67863d7bd1b6a5b9f761a132b
Cr-Commit-Position: refs/heads/master@{#374671}