Removed/Replaced uses of deprecated NSURLConnection methods.

ios/crnet/test/crnet_http_tests.mm

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import <Foundation/Foundation.h>
 #include <stdint.h>
 
 #import "CrNet.h"
 
 #include "base/logging.h"
@@ skipping 176 matching lines @@
   }
 
   base::scoped_nsobject<NSURLSession> session_;
   base::scoped_nsobject<TestDelegate> delegate_;
 
  private:
   base::scoped_nsobject<GCDWebServer> web_server_;
   GURL server_root_;
 };
 
-TEST_F(HttpTest, NSURLConnectionReceivesData) {
-  const char kData[] = "foobar";
-  const char kPath[] = "/foo";
-  RegisterPathText(kPath, kData);
-  StartWebServer();
-
-  NSURL* url = net::NSURLWithGURL(GetURL(kPath));
-  NSURLRequest* req = [NSURLRequest requestWithURL:url];
-  NSURLResponse* resp = nil;
-  NSData* received = [NSURLConnection sendSynchronousRequest:req
-                                           returningResponse:&resp
-                                                       error:nullptr];

[pkl (ping after 24h if needed), 2016/02/09 21:44:14]

Note: +sendSynchronousRequest:returningResponse:error: has been deprecated
starting with iOS9. Since Chrome iOS is now iOS 9 only, this deprecated method
can no longer be used. I'm removing this test because the next test
NSURLSessionReceivesData is already testing the code path for NSURLSession.

[Elly Fong-Jones, 2016/02/10 13:44:12]

You are probably fine to delete these tests, if you only need iOS 9.0+ coverage.

-  EXPECT_EQ(0, memcmp([received bytes], kData, sizeof(kData)));
-}
-
 TEST_F(HttpTest, NSURLSessionReceivesData) {
   const char kPath[] = "/foo";
   const char kData[] = "foobar";
   RegisterPathText(kPath, kData);
   StartWebServer();
 
   NSURL* url = net::NSURLWithGURL(GetURL(kPath));
   NSURLSessionDataTask* task = [session_ dataTaskWithURL:url];
   StartDataTaskAndWaitForCompletion(task);
   EXPECT_EQ(nil, [delegate_ error]);
   EXPECT_EQ(strlen(kData), [delegate_ receivedBytes]);
 }
 
 TEST_F(HttpTest, SdchDisabledByDefault) {
   const char kPath[] = "/foo";
   RegisterPathHandler(kPath,
       ^GCDWebServerResponse* (GCDWebServerRequest* req) {
         EXPECT_FALSE(HeaderValueContains(req, "Accept-Encoding", "sdch"));
         return nil;
       });
   StartWebServer();
   NSURL* url = net::NSURLWithGURL(GetURL(kPath));
-  NSURLRequest* req = [NSURLRequest requestWithURL:url];
-  NSURLResponse* resp = nil;
-  NSError* error = nil;
-  NSData* received = [NSURLConnection sendSynchronousRequest:req
-                                           returningResponse:&resp
-                                                       error:&error];
-  DCHECK(received);
+  NSURLSessionDataTask* task = [session_ dataTaskWithURL:url];
+  StartDataTaskAndWaitForCompletion(task);
+  EXPECT_EQ(nil, [delegate_ error]);
+  EXPECT_TRUE([delegate_ receivedBytes]);
 }
 
 // TODO(ellyjones): There needs to be a test that enabling SDCH works, but
 // because CrNet is static and 'uninstall' only disables it, there is no way to
 // have an individual test enable or disable SDCH.
 // Probably there is a way to get gtest tests to run in a separate process, but
 // I'm not sure what it is.