Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Issue 168083002: cc: Remove RasterWorkerPool::Task. (Closed)

Created:
6 years, 10 months ago by reveman
Modified:
6 years, 10 months ago
Reviewers:
vmpstr, alokp
CC:
chromium-reviews, cc-bugs_chromium.org
Visibility:
Public.

Description

cc: Remove RasterWorkerPool::Task. This removes some unnecessary layers of abstraction between internal::Task and the tile manager. Prerequisite to getting rid of our large raster task objects and anonymous functions. BUG=269841 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251938

Patch Set 1 #

Patch Set 2 : RasterTaskQueue::Task -> RasterTaskQueue::Item #

Total comments: 1

Patch Set 3 : Remove RasterTaskQueueIterator #

Unified diffs Side-by-side diffs Delta from patch set Stats (+240 lines, -379 lines) Patch
M cc/resources/direct_raster_worker_pool.h View 2 chunks +2 lines, -2 lines 0 comments Download
M cc/resources/direct_raster_worker_pool.cc View 1 2 3 chunks +24 lines, -12 lines 0 comments Download
M cc/resources/image_raster_worker_pool.h View 2 chunks +2 lines, -2 lines 0 comments Download
M cc/resources/image_raster_worker_pool.cc View 1 2 3 chunks +16 lines, -7 lines 0 comments Download
M cc/resources/managed_tile_state.h View 1 chunk +1 line, -1 line 0 comments Download
M cc/resources/managed_tile_state.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/resources/pixel_buffer_raster_worker_pool.h View 2 chunks +2 lines, -2 lines 0 comments Download
M cc/resources/pixel_buffer_raster_worker_pool.cc View 1 2 6 chunks +26 lines, -10 lines 0 comments Download
M cc/resources/raster_worker_pool.h View 1 2 5 chunks +31 lines, -130 lines 0 comments Download
M cc/resources/raster_worker_pool.cc View 1 7 chunks +53 lines, -87 lines 0 comments Download
M cc/resources/raster_worker_pool_delegate.h View 1 chunk +1 line, -1 line 0 comments Download
M cc/resources/raster_worker_pool_delegate.cc View 1 chunk +1 line, -2 lines 0 comments Download
M cc/resources/raster_worker_pool_perftest.cc View 1 9 chunks +28 lines, -58 lines 0 comments Download
M cc/resources/raster_worker_pool_unittest.cc View 1 5 chunks +20 lines, -39 lines 0 comments Download
M cc/resources/tile_manager.h View 3 chunks +7 lines, -6 lines 0 comments Download
M cc/resources/tile_manager.cc View 1 9 chunks +19 lines, -16 lines 0 comments Download
M cc/test/fake_tile_manager.cc View 1 2 1 chunk +6 lines, -3 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
reveman
Here's the RasterWorkerPool::Task removal part of my original DirectRasterWorkerPool patch. Please take a look.
6 years, 10 months ago (2014-02-15 01:00:34 UTC) #1
reveman
Renamed RasterTaskQueue::Task to RasterTaskQueue::Item as discussed. PTAL.
6 years, 10 months ago (2014-02-18 20:28:47 UTC) #2
vmpstr
lgtm. Thanks for explaining this. https://codereview.chromium.org/168083002/diff/50001/cc/resources/raster_worker_pool.h File cc/resources/raster_worker_pool.h (right): https://codereview.chromium.org/168083002/diff/50001/cc/resources/raster_worker_pool.h#newcode125 cc/resources/raster_worker_pool.h:125: void Swap(RasterTaskQueue* other); This ...
6 years, 10 months ago (2014-02-18 21:10:22 UTC) #3
reveman
Removed RasterTaskQueueIterator as discussed.
6 years, 10 months ago (2014-02-18 23:48:48 UTC) #4
reveman
The CQ bit was checked by reveman@chromium.org
6 years, 10 months ago (2014-02-18 23:48:58 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/reveman@chromium.org/168083002/110001
6 years, 10 months ago (2014-02-18 23:50:17 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-19 00:03:08 UTC) #7
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) app_list_unittests, ash_unittests, aura_unittests, cacheinvalidation_unittests, cc_unittests, check_deps, ...
6 years, 10 months ago (2014-02-19 00:03:08 UTC) #8
reveman
The CQ bit was checked by reveman@chromium.org
6 years, 10 months ago (2014-02-19 00:04:17 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/reveman@chromium.org/168083002/110001
6 years, 10 months ago (2014-02-19 00:06:53 UTC) #10
commit-bot: I haz the power
6 years, 10 months ago (2014-02-19 02:42:06 UTC) #11
Message was sent while issue was closed.
Change committed as 251938

Powered by Google App Engine
This is Rietveld 408576698