Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Side by Side Diff: cc/resources/image_raster_worker_pool.cc

Issue 168083002: cc: Remove RasterWorkerPool::Task. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Remove RasterTaskQueueIterator Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « cc/resources/image_raster_worker_pool.h ('k') | cc/resources/managed_tile_state.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "cc/resources/image_raster_worker_pool.h" 5 #include "cc/resources/image_raster_worker_pool.h"
6 6
7 #include "base/debug/trace_event.h" 7 #include "base/debug/trace_event.h"
8 #include "base/values.h" 8 #include "base/values.h"
9 #include "cc/debug/traced_value.h" 9 #include "cc/debug/traced_value.h"
10 #include "cc/resources/resource.h" 10 #include "cc/resources/resource.h"
(...skipping 15 matching lines...) Expand all
26 internal::TaskGraphRunner* task_graph_runner, 26 internal::TaskGraphRunner* task_graph_runner,
27 ResourceProvider* resource_provider, 27 ResourceProvider* resource_provider,
28 unsigned texture_target) 28 unsigned texture_target)
29 : RasterWorkerPool(task_graph_runner, resource_provider), 29 : RasterWorkerPool(task_graph_runner, resource_provider),
30 texture_target_(texture_target), 30 texture_target_(texture_target),
31 raster_tasks_pending_(false), 31 raster_tasks_pending_(false),
32 raster_tasks_required_for_activation_pending_(false) {} 32 raster_tasks_required_for_activation_pending_(false) {}
33 33
34 ImageRasterWorkerPool::~ImageRasterWorkerPool() {} 34 ImageRasterWorkerPool::~ImageRasterWorkerPool() {}
35 35
36 void ImageRasterWorkerPool::ScheduleTasks(RasterTask::Queue* queue) { 36 void ImageRasterWorkerPool::ScheduleTasks(RasterTaskQueue* queue) {
37 TRACE_EVENT0("cc", "ImageRasterWorkerPool::ScheduleTasks"); 37 TRACE_EVENT0("cc", "ImageRasterWorkerPool::ScheduleTasks");
38 38
39 DCHECK_EQ(queue->required_for_activation_count,
40 static_cast<size_t>(
41 std::count_if(queue->items.begin(),
42 queue->items.end(),
43 RasterTaskQueue::Item::IsRequiredForActivation)));
44
39 if (!raster_tasks_pending_) 45 if (!raster_tasks_pending_)
40 TRACE_EVENT_ASYNC_BEGIN0("cc", "ScheduledTasks", this); 46 TRACE_EVENT_ASYNC_BEGIN0("cc", "ScheduledTasks", this);
41 47
42 raster_tasks_pending_ = true; 48 raster_tasks_pending_ = true;
43 raster_tasks_required_for_activation_pending_ = true; 49 raster_tasks_required_for_activation_pending_ = true;
44 50
45 unsigned priority = kRasterTaskPriorityBase; 51 unsigned priority = kRasterTaskPriorityBase;
46 52
47 graph_.Reset(); 53 graph_.Reset();
48 54
49 scoped_refptr<internal::WorkerPoolTask> 55 scoped_refptr<internal::WorkerPoolTask>
50 new_raster_required_for_activation_finished_task( 56 new_raster_required_for_activation_finished_task(
51 CreateRasterRequiredForActivationFinishedTask( 57 CreateRasterRequiredForActivationFinishedTask(
52 queue->required_for_activation_count())); 58 queue->required_for_activation_count));
53 scoped_refptr<internal::WorkerPoolTask> new_raster_finished_task( 59 scoped_refptr<internal::WorkerPoolTask> new_raster_finished_task(
54 CreateRasterFinishedTask()); 60 CreateRasterFinishedTask());
55 61
56 for (RasterTaskQueueIterator it(queue); it; ++it) { 62 for (RasterTaskQueue::Item::Vector::const_iterator it = queue->items.begin();
57 internal::RasterWorkerPoolTask* task = *it; 63 it != queue->items.end();
64 ++it) {
65 const RasterTaskQueue::Item& item = *it;
66 internal::RasterWorkerPoolTask* task = item.task;
58 DCHECK(!task->HasCompleted()); 67 DCHECK(!task->HasCompleted());
59 68
60 if (it.required_for_activation()) { 69 if (item.required_for_activation) {
61 graph_.edges.push_back(internal::TaskGraph::Edge( 70 graph_.edges.push_back(internal::TaskGraph::Edge(
62 task, new_raster_required_for_activation_finished_task.get())); 71 task, new_raster_required_for_activation_finished_task.get()));
63 } 72 }
64 73
65 InsertNodeForRasterTask(&graph_, task, task->dependencies(), priority++); 74 InsertNodeForRasterTask(&graph_, task, task->dependencies(), priority++);
66 75
67 graph_.edges.push_back( 76 graph_.edges.push_back(
68 internal::TaskGraph::Edge(task, new_raster_finished_task.get())); 77 internal::TaskGraph::Edge(task, new_raster_finished_task.get()));
69 } 78 }
70 79
71 InsertNodeForTask(&graph_, 80 InsertNodeForTask(&graph_,
72 new_raster_required_for_activation_finished_task.get(), 81 new_raster_required_for_activation_finished_task.get(),
73 kRasterRequiredForActivationFinishedTaskPriority, 82 kRasterRequiredForActivationFinishedTaskPriority,
74 queue->required_for_activation_count()); 83 queue->required_for_activation_count);
75 InsertNodeForTask(&graph_, 84 InsertNodeForTask(&graph_,
76 new_raster_finished_task.get(), 85 new_raster_finished_task.get(),
77 kRasterFinishedTaskPriority, 86 kRasterFinishedTaskPriority,
78 queue->count()); 87 queue->items.size());
79 88
80 raster_tasks_.Swap(queue); 89 raster_tasks_.Swap(queue);
81 90
82 SetTaskGraph(&graph_); 91 SetTaskGraph(&graph_);
83 92
84 set_raster_finished_task(new_raster_finished_task); 93 set_raster_finished_task(new_raster_finished_task);
85 set_raster_required_for_activation_finished_task( 94 set_raster_required_for_activation_finished_task(
86 new_raster_required_for_activation_finished_task); 95 new_raster_required_for_activation_finished_task);
87 96
88 TRACE_EVENT_ASYNC_STEP_INTO1( 97 TRACE_EVENT_ASYNC_STEP_INTO1(
(...skipping 65 matching lines...) Expand 10 before | Expand all | Expand 10 after
154 163
155 scoped_ptr<base::Value> ImageRasterWorkerPool::StateAsValue() const { 164 scoped_ptr<base::Value> ImageRasterWorkerPool::StateAsValue() const {
156 scoped_ptr<base::DictionaryValue> state(new base::DictionaryValue); 165 scoped_ptr<base::DictionaryValue> state(new base::DictionaryValue);
157 166
158 state->SetBoolean("tasks_required_for_activation_pending", 167 state->SetBoolean("tasks_required_for_activation_pending",
159 raster_tasks_required_for_activation_pending_); 168 raster_tasks_required_for_activation_pending_);
160 return state.PassAs<base::Value>(); 169 return state.PassAs<base::Value>();
161 } 170 }
162 171
163 } // namespace cc 172 } // namespace cc
OLDNEW
« no previous file with comments | « cc/resources/image_raster_worker_pool.h ('k') | cc/resources/managed_tile_state.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698