Implement Material Design for Mac toolbar.

Rework the Mac toolbar to use the Material Design style.

BUG=585673
Committed: https://crrev.com/2f68876451cda30218ac57b675f67c196a2df442
Cr-Commit-Position: refs/heads/master@{#379889}

[shrike, 2016-02-27 15:27:05]

Description was changed from

==========
(WIP) Apply Material Design style to the Mac toolbar.

BUG=585673
==========

to

==========
Rework the Mac toolbar to use the Material Design style.

BUG=585673
==========

[shrike, 2016-03-01 00:39:50]

shrike@chromium.org changed reviewers:
+ avi@chromium.org, thakis@chromium.org

[shrike, 2016-03-01 00:40:18]

Hello,

thakis - chrome/chrome_browser_ui.gypi
avi - everything else

PTAL

[Avi (use Gerrit), 2016-03-01 19:59:07]

OMG two ways of doing everything :'(

Mainly a question about dark vs incognito and minor style nits.

https://codereview.chromium.org/1680773006/diff/100001/chrome/browser/ui/coco...
File chrome/browser/ui/cocoa/location_bar/autocomplete_text_field.mm (right):

https://codereview.chromium.org/1680773006/diff/100001/chrome/browser/ui/coco...
chrome/browser/ui/cocoa/location_bar/autocomplete_text_field.mm:375: [[self
window] inIncognitoModeWithSystemTheme]) {
hasDarkTheme?

https://codereview.chromium.org/1680773006/diff/100001/chrome/browser/ui/coco...
File chrome/browser/ui/cocoa/location_bar/autocomplete_text_field_cell.mm
(right):

https://codereview.chromium.org/1680773006/diff/100001/chrome/browser/ui/coco...
chrome/browser/ui/cocoa/location_bar/autocomplete_text_field_cell.mm:296: BOOL
inDarkMode = [[controlView window] inIncognitoModeWithSystemTheme];
hasDarkTheme?

It's not clear when inIncognitoModeWithSystemTheme is appropriate and when
hasDarkTheme is appropriate. On my initial read, it seems like we'd always want
the latter because it's more flexible for weird situations that the user might
put us in.

https://codereview.chromium.org/1680773006/diff/100001/chrome/browser/ui/coco...
File chrome/browser/ui/cocoa/location_bar/autocomplete_text_field_editor.mm
(right):

https://codereview.chromium.org/1680773006/diff/100001/chrome/browser/ui/coco...
chrome/browser/ui/cocoa/location_bar/autocomplete_text_field_editor.mm:93:
NSBackgroundColorAttributeName : textSelectionColor}];
This isn't quite the container literal style that the style guide prescribes.

https://google.github.io/styleguide/objcguide.xml?showone=Container_Literals#...

No shame; every time I do a container literal I have to look it up too.

https://codereview.chromium.org/1680773006/diff/100001/chrome/browser/ui/coco...
File chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.mm (right):

https://codereview.chromium.org/1680773006/diff/100001/chrome/browser/ui/coco...
chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.mm:335: [[field_
window] inIncognitoModeWithSystemTheme]);
hasDarkTheme?

https://codereview.chromium.org/1680773006/diff/100001/chrome/browser/ui/coco...
chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.mm:557: if ([[field_
window] inIncognitoModeWithSystemTheme]) {
hasDarkTheme?

[shrike, 2016-03-01 20:30:14]

Thank you for looking at this so quickly.

PTAL

https://codereview.chromium.org/1680773006/diff/100001/chrome/browser/ui/coco...
File chrome/browser/ui/cocoa/location_bar/autocomplete_text_field.mm (right):

https://codereview.chromium.org/1680773006/diff/100001/chrome/browser/ui/coco...
chrome/browser/ui/cocoa/location_bar/autocomplete_text_field.mm:375: [[self
window] inIncognitoModeWithSystemTheme]) {
On 2016/03/01 19:59:06, Avi wrote:
> hasDarkTheme?

For the omnibox/location bar, we want the dark style when in Incognito mode, but
we don't want it when we're using a dark custom theme. That's primarily because
the dark style uses a gray background that looks good in Incognito mode but not
necessarily with a dark custom theme. So you will see this special
inIncognitoModeWithSystemTheme with omnibox classes but nowhere else.

https://codereview.chromium.org/1680773006/diff/100001/chrome/browser/ui/coco...
File chrome/browser/ui/cocoa/location_bar/autocomplete_text_field_cell.mm
(right):

https://codereview.chromium.org/1680773006/diff/100001/chrome/browser/ui/coco...
chrome/browser/ui/cocoa/location_bar/autocomplete_text_field_cell.mm:296: BOOL
inDarkMode = [[controlView window] inIncognitoModeWithSystemTheme];
On 2016/03/01 19:59:06, Avi wrote:
> hasDarkTheme?
> 
> It's not clear when inIncognitoModeWithSystemTheme is appropriate and when
> hasDarkTheme is appropriate. On my initial read, it seems like we'd always
want
> the latter because it's more flexible for weird situations that the user might
> put us in.

See previous reply.

https://codereview.chromium.org/1680773006/diff/100001/chrome/browser/ui/coco...
File chrome/browser/ui/cocoa/location_bar/autocomplete_text_field_editor.mm
(right):

https://codereview.chromium.org/1680773006/diff/100001/chrome/browser/ui/coco...
chrome/browser/ui/cocoa/location_bar/autocomplete_text_field_editor.mm:93:
NSBackgroundColorAttributeName : textSelectionColor}];
On 2016/03/01 19:59:06, Avi wrote:
> This isn't quite the container literal style that the style guide prescribes.
> 
>
https://google.github.io/styleguide/objcguide.xml?showone=Container_Literals#...
> 
> No shame; every time I do a container literal I have to look it up too.

Acknowledged. Thank you. I think it's correct now, but please double-check.

https://codereview.chromium.org/1680773006/diff/100001/chrome/browser/ui/coco...
File chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.mm (right):

https://codereview.chromium.org/1680773006/diff/100001/chrome/browser/ui/coco...
chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.mm:335: [[field_
window] inIncognitoModeWithSystemTheme]);
On 2016/03/01 19:59:07, Avi wrote:
> hasDarkTheme?

Yes, for location bar.

https://codereview.chromium.org/1680773006/diff/100001/chrome/browser/ui/coco...
chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.mm:557: if ([[field_
window] inIncognitoModeWithSystemTheme]) {
On 2016/03/01 19:59:07, Avi wrote:
> hasDarkTheme?

Yes.

[Avi (use Gerrit), 2016-03-01 20:34:40]

lgtm; thanks for the clarification

[shrike, 2016-03-02 05:20:11]

Hello thakis@ - would you please take a moment to approve the addition of two
files to chrome/chrome_browser_ui.gypi? I'm trying to land this cl ASAP.

[shrike, 2016-03-03 02:31:02]

Hello avi@, would you PTAL at the changes I made to
autocomplete_text_field_cell.mm in the most-recent patchset? Thank you.

[Avi (use Gerrit), 2016-03-03 05:23:12]

Appreciate the attention to detail; still lgtm.

[shrike, 2016-03-07 23:17:51]

avi@ - a few more changes before landing. PTAL.

[Avi (use Gerrit), 2016-03-08 02:02:46]

still lgtm

[shrike, 2016-03-08 18:03:46]

The CQ bit was checked by shrike@chromium.org

[commit-bot: I haz the power, 2016-03-08 18:04:12]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1680773006/150001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1680773006/150001

[commit-bot: I haz the power, 2016-03-08 19:41:20]

Description was changed from

==========
Rework the Mac toolbar to use the Material Design style.

BUG=585673
==========

to

==========
Rework the Mac toolbar to use the Material Design style.

BUG=585673
==========

[commit-bot: I haz the power, 2016-03-08 19:41:21]

Committed patchset #9 (id:150001)

[commit-bot: I haz the power, 2016-03-08 19:42:13]

Description was changed from

==========
Rework the Mac toolbar to use the Material Design style.

BUG=585673
==========

to

==========
Rework the Mac toolbar to use the Material Design style.

BUG=585673

Committed: https://crrev.com/2f68876451cda30218ac57b675f67c196a2df442
Cr-Commit-Position: refs/heads/master@{#379889}
==========

[commit-bot: I haz the power, 2016-03-08 19:42:14]

Patchset 9 (id:??) landed as
https://crrev.com/2f68876451cda30218ac57b675f67c196a2df442
Cr-Commit-Position: refs/heads/master@{#379889}