Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(209)

Issue 1680743007: Revert of command_buffer_gles2: Add test command_buffer_gles2_test for command_buffer_gles2 (Closed)

Created:
4 years, 10 months ago by Nico
Modified:
4 years, 10 months ago
CC:
chromium-reviews, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of command_buffer_gles2: Add test command_buffer_gles2_test for command_buffer_gles2 (patchset #8 id:140001 of https://codereview.chromium.org/1640243002/ ) Reason for revert: This seems to not build in release component builds: https://build.chromium.org/p/chromium.fyi/builders/CrWinClang%28shared%29/builds/7700/steps/compile/logs/stdio FAILED: C:\b\depot_tools\python276_bin\python.exe gyp-win-tool link-with-manifests environment.x86 True command_buffer_gles2_tests.exe "C:\b\depot_tools\python276_bin\python.exe gyp-win-tool link-wrapper environment.x86 False link.exe /nologo /OUT:command_buffer_gles2_tests.exe @command_buffer_gles2_tests.exe.rsp" 1 mt.exe rc.exe "obj\gpu\command_buffer_gles2_tests.command_buffer_gles2_tests.exe.intermediate.manifest" obj\gpu\command_buffer_gles2_tests.command_buffer_gles2_tests.exe.generated.manifest ..\..\build\win\compatibility.manifest command_buffer_gles2_tests.command_buffer_gles2_tests_main.obj : error LNK2019: unresolved external symbol "bool g_command_buffer_gles_has_atexit_manager" (?g_command_buffer_gles_has_atexit_manager@@3_NA) referenced in function _main Original issue's description: > command_buffer_gles2: Add test command_buffer_gles2_test for command_buffer_gles2 > > Add test command_buffer_gles2_test for testing command_buffer_gles2 > library. > > Makes the gpu bots to build target, but the target is not run > on any bot. > > As an example, fix a potential nullptr reference in eglInitialize > and tests the problem. > > Adding the test runner would be useful in order to further develop > command_buffer_gles2. One development direction of the library > would be to extend it enough to support creating OpenGL ES 3.0 > context. > > BUG=581634 > > Committed: https://crrev.com/ee2d13a54fc1de09762f1e5be97d6db44235fa80 > Cr-Commit-Position: refs/heads/master@{#374353} TBR=piman@chromium.org,zmo@google.com,kbr@chromium.org,vmiura@chromium.org,kkinnunen@nvidia.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=581634 Committed: https://crrev.com/9fb9c88c4101275f908f123ec0289d398adb0258 Cr-Commit-Position: refs/heads/master@{#374378}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -263 lines) Patch
M build/all.gyp View 3 chunks +0 lines, -3 lines 0 comments Download
M build/gn_migration.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M gpu/BUILD.gn View 2 chunks +0 lines, -35 lines 0 comments Download
D gpu/command_buffer/tests/command_buffer_gles2_tests_main.cc View 1 chunk +0 lines, -67 lines 0 comments Download
D gpu/command_buffer/tests/egl_test.cc View 1 chunk +0 lines, -36 lines 0 comments Download
D gpu/command_buffer_gles2_tests_apk.isolate View 1 chunk +0 lines, -18 lines 0 comments Download
M gpu/gles2_conform_support/egl/display.cc View 3 chunks +0 lines, -11 lines 0 comments Download
M gpu/gles2_conform_support/egl/egl.cc View 1 chunk +3 lines, -4 lines 0 comments Download
D gpu/gles2_conform_support/egl/test_support.h View 1 chunk +0 lines, -20 lines 0 comments Download
D gpu/gles2_conform_support/egl/test_support.cc View 1 chunk +0 lines, -9 lines 0 comments Download
M gpu/gpu.gyp View 4 chunks +1 line, -59 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Nico
Created Revert of command_buffer_gles2: Add test command_buffer_gles2_test for command_buffer_gles2
4 years, 10 months ago (2016-02-09 15:19:37 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1680743007/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1680743007/1
4 years, 10 months ago (2016-02-09 15:21:32 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-09 15:23:18 UTC) #4
commit-bot: I haz the power
4 years, 10 months ago (2016-02-09 15:24:08 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9fb9c88c4101275f908f123ec0289d398adb0258
Cr-Commit-Position: refs/heads/master@{#374378}

Powered by Google App Engine
This is Rietveld 408576698