Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(151)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 168033003: Pass in correct parameter to MenuController::SelectByChar() on Linux Aura (Closed)

Created:
6 years, 10 months ago by pkotwicz
Modified:
6 years, 10 months ago
Reviewers:
sky
CC:
chromium-reviews, tfarina
Visibility:
Public.

Description

Pass in correct parameter to MenuController::SelectByChar() on Linux Aura BUG=342316 TEST=MenuControllerMnemonicTest*.* Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251917

Patch Set 1 : #

Total comments: 2

Patch Set 2 : #

Patch Set 3 : Fix BookmarkBarViewTest10.KeyEvents #

Unified diffs Side-by-side diffs Delta from patch set Stats (+383 lines, -740 lines) Patch
A chrome/browser/ui/views/menu_controller_interactive_uitest.cc View 1 1 chunk +67 lines, -0 lines 0 comments Download
A chrome/browser/ui/views/menu_controller_test.cc View 1 1 chunk +67 lines, -0 lines 0 comments Download
A + chrome/browser/ui/views/menu_item_view_interactive_uitest.cc View 1 15 chunks +68 lines, -236 lines 0 comments Download
M chrome/browser/ui/views/menu_item_view_test.cc View 1 1 chunk +0 lines, -501 lines 0 comments Download
A chrome/browser/ui/views/menu_test_base.h View 1 chunk +88 lines, -0 lines 0 comments Download
A chrome/browser/ui/views/menu_test_base.cc View 1 1 chunk +84 lines, -0 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 1 chunk +4 lines, -1 line 0 comments Download
M ui/views/controls/menu/menu_controller.cc View 1 2 3 chunks +5 lines, -2 lines 0 comments Download

Messages

Total messages: 18 (0 generated)
pkotwicz
Scott, can you please take a look? Unfortunately writing a test for the menu using ...
6 years, 10 months ago (2014-02-15 18:03:54 UTC) #1
sky
estade is changing related code at https://codereview.chromium.org/167643003/ . Does that take care of this fix?
6 years, 10 months ago (2014-02-18 17:23:34 UTC) #2
pkotwicz
estade@'s CL does not change the signature of MenuController::SelectByChar() so no it does not take ...
6 years, 10 months ago (2014-02-18 17:33:22 UTC) #3
sky
LGTM https://codereview.chromium.org/168033003/diff/80001/chrome/browser/ui/views/menu_controller_test.cc File chrome/browser/ui/views/menu_controller_test.cc (right): https://codereview.chromium.org/168033003/diff/80001/chrome/browser/ui/views/menu_controller_test.cc#newcode1 chrome/browser/ui/views/menu_controller_test.cc:1: // Copyright 2014 The Chromium Authors. All rights ...
6 years, 10 months ago (2014-02-18 17:43:28 UTC) #4
pkotwicz
The CQ bit was checked by pkotwicz@chromium.org
6 years, 10 months ago (2014-02-18 19:51:34 UTC) #5
pkotwicz
The CQ bit was unchecked by pkotwicz@chromium.org
6 years, 10 months ago (2014-02-18 19:52:18 UTC) #6
pkotwicz
The CQ bit was checked by pkotwicz@chromium.org
6 years, 10 months ago (2014-02-18 20:03:39 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pkotwicz@chromium.org/168033003/230003
6 years, 10 months ago (2014-02-18 20:04:04 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-18 21:33:19 UTC) #9
commit-bot: I haz the power
Retried try job too often on linux_chromeos for step(s) interactive_ui_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chromeos&number=203121
6 years, 10 months ago (2014-02-18 21:33:20 UTC) #10
pkotwicz
The CQ bit was checked by pkotwicz@chromium.org
6 years, 10 months ago (2014-02-18 21:40:15 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pkotwicz@chromium.org/168033003/230003
6 years, 10 months ago (2014-02-18 21:40:35 UTC) #12
pkotwicz
The CQ bit was unchecked by pkotwicz@chromium.org
6 years, 10 months ago (2014-02-18 21:40:43 UTC) #13
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-18 21:42:01 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel
6 years, 10 months ago (2014-02-18 21:42:02 UTC) #15
pkotwicz
The CQ bit was checked by pkotwicz@chromium.org
6 years, 10 months ago (2014-02-18 22:09:40 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pkotwicz@chromium.org/168033003/510001
6 years, 10 months ago (2014-02-18 22:13:57 UTC) #17
commit-bot: I haz the power
6 years, 10 months ago (2014-02-19 01:57:01 UTC) #18
Message was sent while issue was closed. 
Change committed as 251917

Powered by Google App Engine
This is Rietveld 408576698