Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(235)

Unified Diff: net/quic/crypto/proof_verifier_chromium.cc

Issue 1679873005: Switch SignatureVerifier to taking an algorithm enum. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix iOS build Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « extensions/browser/verified_contents.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/crypto/proof_verifier_chromium.cc
diff --git a/net/quic/crypto/proof_verifier_chromium.cc b/net/quic/crypto/proof_verifier_chromium.cc
index 9e3b2ec2ca6c246028440ae7177de71bab0c76f7..c5fa6b356942aeca16f31183bdb771e3e661f157 100644
--- a/net/quic/crypto/proof_verifier_chromium.cc
+++ b/net/quic/crypto/proof_verifier_chromium.cc
@@ -365,27 +365,11 @@ bool ProofVerifierChromium::Job::VerifySignature(const string& signed_data,
return false;
}
} else if (type == X509Certificate::kPublicKeyTypeECDSA) {
- // This is the algorithm ID for ECDSA with SHA-256. Parameters are ABSENT.
- // RFC 5758:
- // ecdsa-with-SHA256 OBJECT IDENTIFIER ::= { iso(1) member-body(2)
- // us(840) ansi-X9-62(10045) signatures(4) ecdsa-with-SHA2(3) 2 }
- // ...
- // When the ecdsa-with-SHA224, ecdsa-with-SHA256, ecdsa-with-SHA384, or
- // ecdsa-with-SHA512 algorithm identifier appears in the algorithm field
- // as an AlgorithmIdentifier, the encoding MUST omit the parameters
- // field. That is, the AlgorithmIdentifier SHALL be a SEQUENCE of one
- // component, the OID ecdsa-with-SHA224, ecdsa-with-SHA256, ecdsa-with-
- // SHA384, or ecdsa-with-SHA512.
- // See also RFC 5480, Appendix A.
- static const uint8_t kECDSAWithSHA256AlgorithmID[] = {
- 0x30, 0x0a, 0x06, 0x08, 0x2a, 0x86, 0x48, 0xce, 0x3d, 0x04, 0x03, 0x02,
- };
-
- if (!verifier.VerifyInit(
- kECDSAWithSHA256AlgorithmID, sizeof(kECDSAWithSHA256AlgorithmID),
- reinterpret_cast<const uint8_t*>(signature.data()),
- signature.size(), reinterpret_cast<const uint8_t*>(spki.data()),
- spki.size())) {
+ if (!verifier.VerifyInit(crypto::SignatureVerifier::ECDSA_SHA256,
+ reinterpret_cast<const uint8_t*>(signature.data()),
+ signature.size(),
+ reinterpret_cast<const uint8_t*>(spki.data()),
+ spki.size())) {
DLOG(WARNING) << "VerifyInit failed";
return false;
}
« no previous file with comments | « extensions/browser/verified_contents.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698