Switch SignatureVerifier to taking an algorithm enum.

net/quic/crypto/proof_verifier_chromium.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/quic/crypto/proof_verifier_chromium.h"
 
 #include <utility>
 
 #include "base/bind.h"
 #include "base/bind_helpers.h"
@@ skipping 347 matching lines @@
 
     bool ok = verifier.VerifyInitRSAPSS(
         hash_alg, mask_hash_alg, hash_len,
         reinterpret_cast<const uint8_t*>(signature.data()), signature.size(),
         reinterpret_cast<const uint8_t*>(spki.data()), spki.size());
     if (!ok) {
       DLOG(WARNING) << "VerifyInitRSAPSS failed";
       return false;
     }
   } else if (type == X509Certificate::kPublicKeyTypeECDSA) {
-    // This is the algorithm ID for ECDSA with SHA-256. Parameters are ABSENT.
-    // RFC 5758:
-    //   ecdsa-with-SHA256 OBJECT IDENTIFIER ::= { iso(1) member-body(2)
-    //        us(840) ansi-X9-62(10045) signatures(4) ecdsa-with-SHA2(3) 2 }
-    //   ...
-    //   When the ecdsa-with-SHA224, ecdsa-with-SHA256, ecdsa-with-SHA384, or
-    //   ecdsa-with-SHA512 algorithm identifier appears in the algorithm field
-    //   as an AlgorithmIdentifier, the encoding MUST omit the parameters
-    //   field.  That is, the AlgorithmIdentifier SHALL be a SEQUENCE of one
-    //   component, the OID ecdsa-with-SHA224, ecdsa-with-SHA256, ecdsa-with-
-    //   SHA384, or ecdsa-with-SHA512.
-    // See also RFC 5480, Appendix A.
-    static const uint8_t kECDSAWithSHA256AlgorithmID[] = {
-        0x30, 0x0a, 0x06, 0x08, 0x2a, 0x86, 0x48, 0xce, 0x3d, 0x04, 0x03, 0x02,
-    };
-
-    if (!verifier.VerifyInit(
-            kECDSAWithSHA256AlgorithmID, sizeof(kECDSAWithSHA256AlgorithmID),
-            reinterpret_cast<const uint8_t*>(signature.data()),
-            signature.size(), reinterpret_cast<const uint8_t*>(spki.data()),
-            spki.size())) {
+    if (!verifier.VerifyInit(crypto::SignatureVerifier::ECDSA_SHA256,
+                             reinterpret_cast<const uint8_t*>(signature.data()),
+                             signature.size(),
+                             reinterpret_cast<const uint8_t*>(spki.data()),
+                             spki.size())) {
       DLOG(WARNING) << "VerifyInit failed";
       return false;
     }
   } else {
     LOG(ERROR) << "Unsupported public key type " << type;
     return false;
   }
 
   verifier.VerifyUpdate(reinterpret_cast<const uint8_t*>(kProofSignatureLabel),
                         sizeof(kProofSignatureLabel));
@@ skipping 51 matching lines @@
   }
   return status;
 }
 
 void ProofVerifierChromium::OnJobComplete(Job* job) {
   active_jobs_.erase(job);
   delete job;
 }
 
 }  // namespace net