chrome/browser/extensions/install_signer.cc - Issue 1679873005: Switch SignatureVerifier to taking an algorithm enum.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/install_signer.cc

Issue 1679873005: Switch SignatureVerifier to taking an algorithm enum. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix iOS build Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/extensions/install_signer.cc

diff --git a/chrome/browser/extensions/install_signer.cc b/chrome/browser/extensions/install_signer.cc

index 7ce0ccbdf388811a5274271bfca57a96fea4816b..b4cf0b918394a34db5eb762d28a68e0bb2bcda6d 100644

--- a/chrome/browser/extensions/install_signer.cc

+++ b/chrome/browser/extensions/install_signer.cc

@@ -27,7 +27,6 @@

#include "base/values.h"

#include "build/build_config.h"

#include "chrome/common/chrome_switches.h"

-#include "components/crx_file/constants.h"

#include "crypto/random.h"

#include "crypto/secure_hash.h"

#include "crypto/sha2.h"

@@ -260,7 +259,7 @@ bool InstallSigner::VerifySignature(const InstallSignature& signature) {

crypto::SignatureVerifier verifier;

if (!verifier.VerifyInit(

- crx_file::kSignatureAlgorithm, sizeof(crx_file::kSignatureAlgorithm),

+ crypto::SignatureVerifier::RSA_PKCS1_SHA1,

reinterpret_cast<const uint8_t*>(signature.signature.data()),

signature.signature.size(),

reinterpret_cast<const uint8_t*>(public_key.data()),

« no previous file with comments | « no previous file | components/crx_file.gypi » ('j') | no next file with comments »