Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(183)

Side by Side Diff: chrome/browser/extensions/install_signer.cc

Issue 1679873005: Switch SignatureVerifier to taking an algorithm enum. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix iOS build Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | components/crx_file.gypi » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/extensions/install_signer.h" 5 #include "chrome/browser/extensions/install_signer.h"
6 6
7 #include <stddef.h> 7 #include <stddef.h>
8 #include <stdint.h> 8 #include <stdint.h>
9 #include <utility> 9 #include <utility>
10 10
11 #include "base/base64.h" 11 #include "base/base64.h"
12 #include "base/bind.h" 12 #include "base/bind.h"
13 #include "base/command_line.h" 13 #include "base/command_line.h"
14 #include "base/json/json_reader.h" 14 #include "base/json/json_reader.h"
15 #include "base/json/json_writer.h" 15 #include "base/json/json_writer.h"
16 #include "base/lazy_instance.h" 16 #include "base/lazy_instance.h"
17 #include "base/macros.h" 17 #include "base/macros.h"
18 #include "base/message_loop/message_loop.h" 18 #include "base/message_loop/message_loop.h"
19 #include "base/metrics/histogram.h" 19 #include "base/metrics/histogram.h"
20 #include "base/process/process_info.h" 20 #include "base/process/process_info.h"
21 #include "base/stl_util.h" 21 #include "base/stl_util.h"
22 #include "base/strings/string_number_conversions.h" 22 #include "base/strings/string_number_conversions.h"
23 #include "base/strings/string_split.h" 23 #include "base/strings/string_split.h"
24 #include "base/strings/string_util.h" 24 #include "base/strings/string_util.h"
25 #include "base/strings/stringprintf.h" 25 #include "base/strings/stringprintf.h"
26 #include "base/time/time.h" 26 #include "base/time/time.h"
27 #include "base/values.h" 27 #include "base/values.h"
28 #include "build/build_config.h" 28 #include "build/build_config.h"
29 #include "chrome/common/chrome_switches.h" 29 #include "chrome/common/chrome_switches.h"
30 #include "components/crx_file/constants.h"
31 #include "crypto/random.h" 30 #include "crypto/random.h"
32 #include "crypto/secure_hash.h" 31 #include "crypto/secure_hash.h"
33 #include "crypto/sha2.h" 32 #include "crypto/sha2.h"
34 #include "crypto/signature_verifier.h" 33 #include "crypto/signature_verifier.h"
35 #include "net/url_request/url_fetcher.h" 34 #include "net/url_request/url_fetcher.h"
36 #include "net/url_request/url_fetcher_delegate.h" 35 #include "net/url_request/url_fetcher_delegate.h"
37 #include "net/url_request/url_request_context_getter.h" 36 #include "net/url_request/url_request_context_getter.h"
38 #include "net/url_request/url_request_status.h" 37 #include "net/url_request/url_request_status.h"
39 #include "url/gurl.h" 38 #include "url/gurl.h"
40 39
(...skipping 212 matching lines...) Expand 10 before | Expand all | Expand 10 after
253 signed_data.append(hash_base64); 252 signed_data.append(hash_base64);
254 253
255 signed_data.append(signature.expire_date); 254 signed_data.append(signature.expire_date);
256 255
257 std::string public_key; 256 std::string public_key;
258 if (!Extension::ParsePEMKeyBytes(kPublicKeyPEM, &public_key)) 257 if (!Extension::ParsePEMKeyBytes(kPublicKeyPEM, &public_key))
259 return false; 258 return false;
260 259
261 crypto::SignatureVerifier verifier; 260 crypto::SignatureVerifier verifier;
262 if (!verifier.VerifyInit( 261 if (!verifier.VerifyInit(
263 crx_file::kSignatureAlgorithm, sizeof(crx_file::kSignatureAlgorithm), 262 crypto::SignatureVerifier::RSA_PKCS1_SHA1,
264 reinterpret_cast<const uint8_t*>(signature.signature.data()), 263 reinterpret_cast<const uint8_t*>(signature.signature.data()),
265 signature.signature.size(), 264 signature.signature.size(),
266 reinterpret_cast<const uint8_t*>(public_key.data()), 265 reinterpret_cast<const uint8_t*>(public_key.data()),
267 public_key.size())) 266 public_key.size()))
268 return false; 267 return false;
269 268
270 verifier.VerifyUpdate(reinterpret_cast<const uint8_t*>(signed_data.data()), 269 verifier.VerifyUpdate(reinterpret_cast<const uint8_t*>(signed_data.data()),
271 signed_data.size()); 270 signed_data.size());
272 return verifier.VerifyFinal(); 271 return verifier.VerifyFinal();
273 } 272 }
(...skipping 232 matching lines...) Expand 10 before | Expand all | Expand 10 after
506 if (!verified) 505 if (!verified)
507 result.reset(); 506 result.reset();
508 } 507 }
509 508
510 if (!callback_.is_null()) 509 if (!callback_.is_null())
511 callback_.Run(std::move(result)); 510 callback_.Run(std::move(result));
512 } 511 }
513 512
514 513
515 } // namespace extensions 514 } // namespace extensions
OLDNEW
« no previous file with comments | « no previous file | components/crx_file.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698