Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(229)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1679853002: VM: Move redundancy elimination phases into a separate file. (Closed)

Created:
4 years, 10 months ago by Florian Schneider
Modified:
4 years, 10 months ago
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

VM: Move redundancy elimination phases into a separate file. Reorganizing these is part of splitting flow_graph_optimizer.cc into a JIT- and a precompiler-specific part. Most of the phases in redundancy_elimination.cc can be shared unchanged between compilers. BUG= R=vegorov@google.com Committed: https://github.com/dart-lang/sdk/commit/d39c867369cab072ed9817a705d907beb89667d6

Patch Set 1 #

Total comments: 2

Patch Set 2 : fixed indentation #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3681 lines, -3631 lines) Patch
M runtime/vm/compiler.cc View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/vm/flow_graph.h View 1 1 chunk +6 lines, -0 lines 0 comments Download
M runtime/vm/flow_graph.cc View 1 chunk +37 lines, -0 lines 0 comments Download
M runtime/vm/flow_graph_optimizer.h View 1 chunk +0 lines, -132 lines 0 comments Download
M runtime/vm/flow_graph_optimizer.cc View 5 chunks +15 lines, -3499 lines 0 comments Download
A runtime/vm/redundancy_elimination.h View 1 chunk +149 lines, -0 lines 0 comments Download
A runtime/vm/redundancy_elimination.cc View 1 chunk +3471 lines, -0 lines 0 comments Download
M runtime/vm/vm_sources.gypi View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Florian Schneider
4 years, 10 months ago (2016-02-08 16:53:39 UTC) #2
Vyacheslav Egorov (Google)
lgtm https://codereview.chromium.org/1679853002/diff/1/runtime/vm/flow_graph.h File runtime/vm/flow_graph.h (right): https://codereview.chromium.org/1679853002/diff/1/runtime/vm/flow_graph.h#newcode150 runtime/vm/flow_graph.h:150: Instruction* current, indentation.
4 years, 10 months ago (2016-02-08 16:55:47 UTC) #3
Florian Schneider
https://codereview.chromium.org/1679853002/diff/1/runtime/vm/flow_graph.h File runtime/vm/flow_graph.h (right): https://codereview.chromium.org/1679853002/diff/1/runtime/vm/flow_graph.h#newcode150 runtime/vm/flow_graph.h:150: Instruction* current, On 2016/02/08 16:55:47, Vyacheslav Egorov (Google) wrote: ...
4 years, 10 months ago (2016-02-08 16:58:01 UTC) #4
Florian Schneider
4 years, 10 months ago (2016-02-08 17:08:21 UTC) #6
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
d39c867369cab072ed9817a705d907beb89667d6 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698