Create dist jars only for instrumentation apks; use ijars for them

Create dist jars only for instrumentation apks; use ijars for them

Since the dist jar is used only for extracting the list of tests,
there's no need to create one for every apk.

Using interface jars rather than normal jars speeds up test calculation
time for ChromePublicTestApk 17s -> 5s on my machine.

Even better would be to address the TODO and create the test list at
build time, but might as well pick this lower-hanging fruit :).

BUG=none

Committed: https://crrev.com/b13c048454a8755e0d4ebc584b1003c2b829b2b5
Cr-Commit-Position: refs/heads/master@{#374181}

[agrieve, 2016-02-06 19:11:06]

The CQ bit was checked by agrieve@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-02-06 19:11:12]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1679623002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1679623002/1

[commit-bot: I haz the power, 2016-02-07 04:28:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-07 04:28:23]

Dry run: This issue passed the CQ dry run.

[agrieve, 2016-02-08 14:52:13]

Description was changed from

==========
Create dist jars only for instrumentation apks; use ijars for them

Since the dist jar is used only for extracting the list of tests,
there's no need to create one for every apk.

Using interface jars rather than normal jars speeds up test calculation
time for ChromePublicTestApk 17s -> 5s on my machine.

Even better would be to address the TODO and create the test list at
build time, but might as well pick this lower-hanging fruit :).

BUG=none
==========

to

==========
Create dist jars only for instrumentation apks; use ijars for them

Since the dist jar is used only for extracting the list of tests,
there's no need to create one for every apk.

Using interface jars rather than normal jars speeds up test calculation
time for ChromePublicTestApk 17s -> 5s on my machine.

Even better would be to address the TODO and create the test list at
build time, but might as well pick this lower-hanging fruit :).

BUG=none
==========

[agrieve, 2016-02-08 14:52:13]

agrieve@chromium.org changed reviewers:
+ jbudorick@chromium.org

[agrieve, 2016-02-08 14:52:34]

On 2016/02/07 04:28:23, commit-bot: I haz the power wrote:
> Dry run: This issue passed the CQ dry run.

🐰

[jbudorick, 2016-02-08 16:24:13]

https://codereview.chromium.org/1679623002/diff/1/build/android/gyp/create_di...
File build/android/gyp/create_dist_jar.py (right):

https://codereview.chromium.org/1679623002/diff/1/build/android/gyp/create_di...
build/android/gyp/create_dist_jar.py:20: parser.add_option('--use-ijars',
action='store_true',
If we only use dist jars for instrumentation test APKs and we're switching those
to use ijars, why is this an option at all?

https://codereview.chromium.org/1679623002/diff/1/build/android/gyp/util/buil...
File build/android/gyp/util/build_utils.py (right):

https://codereview.chromium.org/1679623002/diff/1/build/android/gyp/util/buil...
build/android/gyp/util/build_utils.py:335: if hasattr(info, 'CRC'):
do we only call this function for ijars...?

https://codereview.chromium.org/1679623002/diff/1/build/config/android/rules.gni
File build/config/android/rules.gni (right):

https://codereview.chromium.org/1679623002/diff/1/build/config/android/rules....
build/config/android/rules.gni:1551: "--use-ijars",
also, why is this GN-only?

[agrieve, 2016-02-08 16:42:01]

https://codereview.chromium.org/1679623002/diff/1/build/android/gyp/create_di...
File build/android/gyp/create_dist_jar.py (right):

https://codereview.chromium.org/1679623002/diff/1/build/android/gyp/create_di...
build/android/gyp/create_dist_jar.py:20: parser.add_option('--use-ijars',
action='store_true',
On 2016/02/08 16:24:12, jbudorick wrote:
> If we only use dist jars for instrumentation test APKs and we're switching
those
> to use ijars, why is this an option at all?

GYP doesn't create interface jars.

https://codereview.chromium.org/1679623002/diff/1/build/android/gyp/util/buil...
File build/android/gyp/util/build_utils.py (right):

https://codereview.chromium.org/1679623002/diff/1/build/android/gyp/util/buil...
build/android/gyp/util/build_utils.py:335: if hasattr(info, 'CRC'):
On 2016/02/08 16:24:12, jbudorick wrote:
> do we only call this function for ijars...?

It's only needed for ijars, but I don't think verifying CRCs of zip entries is
useful for us anyways.

https://codereview.chromium.org/1679623002/diff/1/build/config/android/rules.gni
File build/config/android/rules.gni (right):

https://codereview.chromium.org/1679623002/diff/1/build/config/android/rules....
build/config/android/rules.gni:1551: "--use-ijars",
On 2016/02/08 16:24:12, jbudorick wrote:
> also, why is this GN-only?

When I first added ijars, I was too lazy to port them to GYP as well :P

[jbudorick, 2016-02-08 16:59:11]

lgtm

https://codereview.chromium.org/1679623002/diff/1/build/android/gyp/util/buil...
File build/android/gyp/util/build_utils.py (right):

https://codereview.chromium.org/1679623002/diff/1/build/android/gyp/util/buil...
build/android/gyp/util/build_utils.py:335: if hasattr(info, 'CRC'):
On 2016/02/08 16:42:01, agrieve wrote:
> On 2016/02/08 16:24:12, jbudorick wrote:
> > do we only call this function for ijars...?
> 
> It's only needed for ijars, but I don't think verifying CRCs of zip entries is
> useful for us anyways.

sgtm

https://codereview.chromium.org/1679623002/diff/1/build/config/android/rules.gni
File build/config/android/rules.gni (right):

https://codereview.chromium.org/1679623002/diff/1/build/config/android/rules....
build/config/android/rules.gni:1551: "--use-ijars",
On 2016/02/08 16:42:01, agrieve wrote:
> On 2016/02/08 16:24:12, jbudorick wrote:
> > also, why is this GN-only?
> 
> When I first added ijars, I was too lazy to port them to GYP as well :P

assuming you mean dist jars here instead of ijars

[agrieve, 2016-02-08 17:56:14]

The CQ bit was checked by agrieve@chromium.org

[commit-bot: I haz the power, 2016-02-08 17:58:16]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1679623002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1679623002/1

[commit-bot: I haz the power, 2016-02-08 21:25:49]

Description was changed from

==========
Create dist jars only for instrumentation apks; use ijars for them

Since the dist jar is used only for extracting the list of tests,
there's no need to create one for every apk.

Using interface jars rather than normal jars speeds up test calculation
time for ChromePublicTestApk 17s -> 5s on my machine.

Even better would be to address the TODO and create the test list at
build time, but might as well pick this lower-hanging fruit :).

BUG=none
==========

to

==========
Create dist jars only for instrumentation apks; use ijars for them

Since the dist jar is used only for extracting the list of tests,
there's no need to create one for every apk.

Using interface jars rather than normal jars speeds up test calculation
time for ChromePublicTestApk 17s -> 5s on my machine.

Even better would be to address the TODO and create the test list at
build time, but might as well pick this lower-hanging fruit :).

BUG=none
==========

[commit-bot: I haz the power, 2016-02-08 21:25:50]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-02-08 21:28:29]

Description was changed from

==========
Create dist jars only for instrumentation apks; use ijars for them

Since the dist jar is used only for extracting the list of tests,
there's no need to create one for every apk.

Using interface jars rather than normal jars speeds up test calculation
time for ChromePublicTestApk 17s -> 5s on my machine.

Even better would be to address the TODO and create the test list at
build time, but might as well pick this lower-hanging fruit :).

BUG=none
==========

to

==========
Create dist jars only for instrumentation apks; use ijars for them

Since the dist jar is used only for extracting the list of tests,
there's no need to create one for every apk.

Using interface jars rather than normal jars speeds up test calculation
time for ChromePublicTestApk 17s -> 5s on my machine.

Even better would be to address the TODO and create the test list at
build time, but might as well pick this lower-hanging fruit :).

BUG=none

Committed: https://crrev.com/b13c048454a8755e0d4ebc584b1003c2b829b2b5
Cr-Commit-Position: refs/heads/master@{#374181}
==========

[commit-bot: I haz the power, 2016-02-08 21:28:31]

Patchset 1 (id:??) landed as
https://crrev.com/b13c048454a8755e0d4ebc584b1003c2b829b2b5
Cr-Commit-Position: refs/heads/master@{#374181}