Make instrumentation_test_apk depend on their apk_under_test.

Make instrumentation_test_apk depend on their apk_under_test.

The test runner tries to install the apk_under_test, so it makes sense
that building the test should also build the apk_under_test.

BUG=none

Committed: https://crrev.com/6c2fbb438add5f31cd9d37e580c4735a4c7becab
Cr-Commit-Position: refs/heads/master@{#374402}

[agrieve, 2016-02-08 14:52:53]

Description was changed from

==========
Make instrumentation_test_apk depend on their apk_under_test.

The test runner tries to install the apk_under_test, so it makes sense
that building the test should also build the apk_under_test.

BUG=none
==========

to

==========
Make instrumentation_test_apk depend on their apk_under_test.

The test runner tries to install the apk_under_test, so it makes sense
that building the test should also build the apk_under_test.

BUG=none
==========

[agrieve, 2016-02-08 14:52:53]

agrieve@chromium.org changed reviewers:
+ jbudorick@chromium.org

[agrieve, 2016-02-08 14:53:10]

On 2016/02/08 14:52:53, agrieve wrote:
> mailto:agrieve@chromium.org changed reviewers:
> + mailto:jbudorick@chromium.org

🐢

[jbudorick, 2016-02-08 16:18:22]

lgtm

https://codereview.chromium.org/1677903002/diff/1/build/config/android/rules.gni
File build/config/android/rules.gni (right):

https://codereview.chromium.org/1677903002/diff/1/build/config/android/rules....
build/config/android/rules.gni:1975: invoker.apk_under_test,
We kind of do this implicitly already down in write_build_config
(https://code.google.com/p/chromium/codesearch#chromium/src/build/config/andro...)
but I'm fine with being more explicit about it.

[agrieve, 2016-02-09 16:42:18]

https://codereview.chromium.org/1677903002/diff/1/build/config/android/rules.gni
File build/config/android/rules.gni (right):

https://codereview.chromium.org/1677903002/diff/1/build/config/android/rules....
build/config/android/rules.gni:1975: invoker.apk_under_test,
On 2016/02/08 16:18:22, jbudorick wrote:
> We kind of do this implicitly already down in write_build_config
>
(https://code.google.com/p/chromium/codesearch#chromium/src/build/config/andro...)
> but I'm fine with being more explicit about it.

ahh, I see! I've changed that line to just depend on the build config. This
enables more concurrency (chrome and test apk can be packaged at the same time)

[agrieve, 2016-02-09 16:42:23]

The CQ bit was checked by agrieve@chromium.org

[agrieve, 2016-02-09 16:42:24]

The patchset sent to the CQ was uploaded after l-g-t-m from
jbudorick@chromium.org
Link to the patchset: https://codereview.chromium.org/1677903002/#ps20001
(title: "build_config")

[commit-bot: I haz the power, 2016-02-09 16:42:51]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1677903002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1677903002/20001

[commit-bot: I haz the power, 2016-02-09 17:24:05]

Description was changed from

==========
Make instrumentation_test_apk depend on their apk_under_test.

The test runner tries to install the apk_under_test, so it makes sense
that building the test should also build the apk_under_test.

BUG=none
==========

to

==========
Make instrumentation_test_apk depend on their apk_under_test.

The test runner tries to install the apk_under_test, so it makes sense
that building the test should also build the apk_under_test.

BUG=none
==========

[commit-bot: I haz the power, 2016-02-09 17:24:05]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-02-09 17:25:10]

Description was changed from

==========
Make instrumentation_test_apk depend on their apk_under_test.

The test runner tries to install the apk_under_test, so it makes sense
that building the test should also build the apk_under_test.

BUG=none
==========

to

==========
Make instrumentation_test_apk depend on their apk_under_test.

The test runner tries to install the apk_under_test, so it makes sense
that building the test should also build the apk_under_test.

BUG=none

Committed: https://crrev.com/6c2fbb438add5f31cd9d37e580c4735a4c7becab
Cr-Commit-Position: refs/heads/master@{#374402}
==========

[commit-bot: I haz the power, 2016-02-09 17:25:12]

Patchset 2 (id:??) landed as
https://crrev.com/6c2fbb438add5f31cd9d37e580c4735a4c7becab
Cr-Commit-Position: refs/heads/master@{#374402}

[iclelland, 2016-02-09 20:13:36]

A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/1683823002/ by iclelland@chromium.org.

The reason for reverting is: Build is broken:
compile

Revision range:
chromium 374412 : 374420

Failing builders:
Android GN (dbg):
https://build.chromium.org/p/chromium.linux/builders/Android%20GN%20(dbg)

Appears to be caused by crrev.com/6c2fbb438add5f31cd9d37e580c4735a4c7becab

This didn't cause failures immediately; I suspect that it took a DEPS update to
cause a full build before the offending APK was a problem.