Reenable and strengthen screenshot_sync test.

Reenable and strengthen screenshot_sync test.

It looks like the mechanism this test uses may have been made reliable
since the time Issue 459820 was filed about it. A variant of the test
would have caught the regression just introduced in Issue 584381, so
reenable the test, and sample more pixels in the snapshot.

BUG=459820, 584381
Committed: https://crrev.com/f0cfd18530b0e212c8586aa26f02e47aa984c921
Cr-Commit-Position: refs/heads/master@{#374026}

[Ken Russell (switch to Gerrit), 2016-02-06 02:28:14]

kbr@chromium.org changed reviewers:
+ vmiura@chromium.org

[Ken Russell (switch to Gerrit), 2016-02-06 02:28:15]

Please review. Thanks.

The screenshot_sync_divs.html test definitely catches the regression introduced
in https://codereview.chromium.org/1666203003 .

[Ken Russell (switch to Gerrit), 2016-02-06 02:28:35]

On 2016/02/06 02:28:15, Ken Russell wrote:
> Please review. Thanks.
> 
> The screenshot_sync_divs.html test definitely catches the regression
introduced
> in https://codereview.chromium.org/1666203003 .

I should have said "reliably catches".

[vmiura, 2016-02-06 02:44:37]

https://codereview.chromium.org/1679593002/diff/20001/content/test/data/gpu/s...
File content/test/data/gpu/screenshot_sync_divs.html (right):

https://codereview.chromium.org/1679593002/diff/20001/content/test/data/gpu/s...
content/test/data/gpu/screenshot_sync_divs.html:11: <div id="testdiv"
style="position: absolute; left; 0px; top: 0px; width: 192px; height: 192px;
will-change: transform; background-color: rgb(255, 0, 0);">.</div>
Please inset inner div so it does not also start at 0,0.
Colon instead of semi colon after "left" property.

[Ken Russell (switch to Gerrit), 2016-02-06 02:45:15]

https://codereview.chromium.org/1679593002/diff/20001/content/test/data/gpu/s...
File content/test/data/gpu/screenshot_sync_divs.html (right):

https://codereview.chromium.org/1679593002/diff/20001/content/test/data/gpu/s...
content/test/data/gpu/screenshot_sync_divs.html:11: <div id="testdiv"
style="position: absolute; left; 0px; top: 0px; width: 192px; height: 192px;
will-change: transform; background-color: rgb(255, 0, 0);">.</div>
On 2016/02/06 02:44:37, vmiura wrote:
> Please inset inner div so it does not also start at 0,0.
> Colon instead of semi colon after "left" property.

Done.

[vmiura, 2016-02-06 02:46:24]

LGTM

[Ken Russell (switch to Gerrit), 2016-02-06 02:46:38]

The CQ bit was checked by kbr@chromium.org

[commit-bot: I haz the power, 2016-02-06 02:47:10]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1679593002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1679593002/40001

[commit-bot: I haz the power, 2016-02-06 03:39:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-06 03:39:07]

Try jobs failed on following builders:
  linux_android_rel_ng on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[Ken Russell (switch to Gerrit), 2016-02-06 04:13:38]

The CQ bit was checked by kbr@chromium.org

[commit-bot: I haz the power, 2016-02-06 04:13:59]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1679593002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1679593002/40001

[commit-bot: I haz the power, 2016-02-06 04:48:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-06 04:48:30]

Try jobs failed on following builders:
  linux_android_rel_ng on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[Ken Russell (switch to Gerrit), 2016-02-06 07:41:31]

The CQ bit was checked by kbr@chromium.org

[commit-bot: I haz the power, 2016-02-06 07:41:53]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1679593002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1679593002/40001

[commit-bot: I haz the power, 2016-02-06 10:08:00]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-02-06 10:09:34]

Description was changed from

==========
Reenable and strengthen screenshot_sync test.

It looks like the mechanism this test uses may have been made reliable
since the time Issue 459820 was filed about it. A variant of the test
would have caught the regression just introduced in Issue 584381, so
reenable the test, and sample more pixels in the snapshot.

BUG=459820,584381
==========

to

==========
Reenable and strengthen screenshot_sync test.

It looks like the mechanism this test uses may have been made reliable
since the time Issue 459820 was filed about it. A variant of the test
would have caught the regression just introduced in Issue 584381, so
reenable the test, and sample more pixels in the snapshot.

BUG=459820,584381

Committed: https://crrev.com/f0cfd18530b0e212c8586aa26f02e47aa984c921
Cr-Commit-Position: refs/heads/master@{#374026}
==========

[commit-bot: I haz the power, 2016-02-06 10:09:35]

Patchset 3 (id:??) landed as
https://crrev.com/f0cfd18530b0e212c8586aa26f02e47aa984c921
Cr-Commit-Position: refs/heads/master@{#374026}