chrome/browser/about_flags.cc - Issue 1679223003: [NTP Snippets] Make a base::Feature instead of raw cmdline flag

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/about_flags.cc

Issue 1679223003: [NTP Snippets] Make a base::Feature instead of raw cmdline flag (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@may_ntp

Patch Set: rebase Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/about_flags.cc

diff --git a/chrome/browser/about_flags.cc b/chrome/browser/about_flags.cc

index 7a315a1ee92772e1c034df885b4aaa8e29b9e76b..a9514540bc641086b9f71f7cd62dc45a52066914 100644

--- a/chrome/browser/about_flags.cc

+++ b/chrome/browser/about_flags.cc

@@ -1810,6 +1810,11 @@ const FeatureEntry kFeatureEntries[] = {

IDS_FLAG_ENABLE_TAB_FOR_DESKTOP_SHARE_DESCRIPTION, kOsAll,

SINGLE_VALUE_TYPE(extensions::switches::kEnableTabForDesktopShare)}

#endif

+#if defined(OS_ANDROID)

+ {"enable-ntp-snippets", IDS_FLAGS_ENABLE_NTP_SNIPPETS_NAME,

+ IDS_FLAGS_ENABLE_NTP_SNIPPETS_DESCRIPTION, kOsAndroid,

+ FEATURE_VALUE_TYPE(chrome::android::kNTPSnippetsFeature)},

+#endif // defined(OS_ANDROID)

// NOTE: Adding new command-line switches requires adding corresponding

// entries to enum "LoginCustomFlags" in histograms.xml. See note in

// histograms.xml and don't forget to run AboutFlagsHistogramTest unit test.

« no previous file with comments | « chrome/app/generated_resources.grd ('k') | chrome/browser/android/chrome_feature_list.h » ('j') | no next file with comments »