Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1004)

Side by Side Diff: chrome/browser/about_flags.cc

Issue 1679223003: [NTP Snippets] Make a base::Feature instead of raw cmdline flag (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@may_ntp
Patch Set: rebase Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/app/generated_resources.grd ('k') | chrome/browser/android/chrome_feature_list.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/about_flags.h" 5 #include "chrome/browser/about_flags.h"
6 6
7 #include <iterator> 7 #include <iterator>
8 #include <map> 8 #include <map>
9 #include <set> 9 #include <set>
10 #include <utility> 10 #include <utility>
(...skipping 1792 matching lines...) Expand 10 before | Expand all | Expand 10 after
1803 {"enable-audio-support-for-desktop-share", 1803 {"enable-audio-support-for-desktop-share",
1804 IDS_FLAG_ENABLE_AUDIO_FOR_DESKTOP_SHARE, 1804 IDS_FLAG_ENABLE_AUDIO_FOR_DESKTOP_SHARE,
1805 IDS_FLAG_ENABLE_AUDIO_FOR_DESKTOP_SHARE_DESCRIPTION, 1805 IDS_FLAG_ENABLE_AUDIO_FOR_DESKTOP_SHARE_DESCRIPTION,
1806 kOsAll, 1806 kOsAll,
1807 SINGLE_VALUE_TYPE(switches::kEnableAudioSupportForDesktopShare)}, 1807 SINGLE_VALUE_TYPE(switches::kEnableAudioSupportForDesktopShare)},
1808 #if defined(ENABLE_EXTENSIONS) 1808 #if defined(ENABLE_EXTENSIONS)
1809 {"enable-tab-for-desktop-share", IDS_FLAG_ENABLE_TAB_FOR_DESKTOP_SHARE, 1809 {"enable-tab-for-desktop-share", IDS_FLAG_ENABLE_TAB_FOR_DESKTOP_SHARE,
1810 IDS_FLAG_ENABLE_TAB_FOR_DESKTOP_SHARE_DESCRIPTION, kOsAll, 1810 IDS_FLAG_ENABLE_TAB_FOR_DESKTOP_SHARE_DESCRIPTION, kOsAll,
1811 SINGLE_VALUE_TYPE(extensions::switches::kEnableTabForDesktopShare)} 1811 SINGLE_VALUE_TYPE(extensions::switches::kEnableTabForDesktopShare)}
1812 #endif 1812 #endif
1813 #if defined(OS_ANDROID)
1814 {"enable-ntp-snippets", IDS_FLAGS_ENABLE_NTP_SNIPPETS_NAME,
1815 IDS_FLAGS_ENABLE_NTP_SNIPPETS_DESCRIPTION, kOsAndroid,
1816 FEATURE_VALUE_TYPE(chrome::android::kNTPSnippetsFeature)},
1817 #endif // defined(OS_ANDROID)
1813 // NOTE: Adding new command-line switches requires adding corresponding 1818 // NOTE: Adding new command-line switches requires adding corresponding
1814 // entries to enum "LoginCustomFlags" in histograms.xml. See note in 1819 // entries to enum "LoginCustomFlags" in histograms.xml. See note in
1815 // histograms.xml and don't forget to run AboutFlagsHistogramTest unit test. 1820 // histograms.xml and don't forget to run AboutFlagsHistogramTest unit test.
1816 }; 1821 };
1817 1822
1818 class FlagsStateSingleton { 1823 class FlagsStateSingleton {
1819 public: 1824 public:
1820 FlagsStateSingleton() 1825 FlagsStateSingleton()
1821 : flags_state_(kFeatureEntries, arraysize(kFeatureEntries)) {} 1826 : flags_state_(kFeatureEntries, arraysize(kFeatureEntries)) {}
1822 ~FlagsStateSingleton() {} 1827 ~FlagsStateSingleton() {}
(...skipping 201 matching lines...) Expand 10 before | Expand all | Expand 10 after
2024 const base::HistogramBase::Sample kBadSwitchFormatHistogramId = 0; 2029 const base::HistogramBase::Sample kBadSwitchFormatHistogramId = 0;
2025 2030
2026 const FeatureEntry* GetFeatureEntries(size_t* count) { 2031 const FeatureEntry* GetFeatureEntries(size_t* count) {
2027 *count = arraysize(kFeatureEntries); 2032 *count = arraysize(kFeatureEntries);
2028 return kFeatureEntries; 2033 return kFeatureEntries;
2029 } 2034 }
2030 2035
2031 } // namespace testing 2036 } // namespace testing
2032 2037
2033 } // namespace about_flags 2038 } // namespace about_flags
OLDNEW
« no previous file with comments | « chrome/app/generated_resources.grd ('k') | chrome/browser/android/chrome_feature_list.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698