chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageView.java - Issue 1679223003: [NTP Snippets] Make a base::Feature instead of raw cmdline flag

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageView.java

Issue 1679223003: [NTP Snippets] Make a base::Feature instead of raw cmdline flag (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@may_ntp

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java ('K') | « chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java ('k') | chrome/app/generated_resources.grd » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageView.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageView.java b/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageView.java

index 6c665c9dc0c61b15a8959dbf59a6a51d9feae472..3fbee4af8dbb662a91ff828681362e5411b95cdc 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageView.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageView.java

@@ -34,12 +34,11 @@ import android.widget.FrameLayout;

import android.widget.ImageView;

import android.widget.TextView;

-import org.chromium.base.CommandLine;

import org.chromium.base.VisibleForTesting;

import org.chromium.base.metrics.RecordHistogram;

import org.chromium.base.metrics.RecordUserAction;

import org.chromium.chrome.R;

-import org.chromium.chrome.browser.ChromeSwitches;

+import org.chromium.chrome.browser.ChromeFeatureList;

import org.chromium.chrome.browser.favicon.FaviconHelper.FaviconImageCallback;

import org.chromium.chrome.browser.favicon.FaviconHelper.IconAvailabilityCallback;

import org.chromium.chrome.browser.favicon.LargeIconBridge.LargeIconCallback;

@@ -334,7 +333,7 @@ public class NewTabPageView extends FrameLayout

if (mManager.shouldShowOptOutPromo()) showOptOutPromo();

// Set up snippets

- if (CommandLine.getInstance().hasSwitch(ChromeSwitches.ENABLE_NTP_SNIPPETS)) {

+ if (ChromeFeatureList.isEnabled("NTPSnippets")) {

mSnippetsManager = snippetsManager;

mSnippetsView = (RecyclerView) findViewById(R.id.snippets_card_list);

mSnippetsView.setVisibility(View.VISIBLE);