[NTP Snippets] Make a base::Feature instead of raw cmdline flag

chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java

Index: chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java b/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java
index ff9d4cce92ef3a9d4ea5d889b5067e61e06d1b37..7def9c039bd16b065a3dcaaad42395f920683ac1 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java
@@ -640,7 +640,7 @@ public class NewTabPage
     }
 
     private void updateSearchProviderHasLogo() {
-        if (CommandLine.getInstance().hasSwitch(ChromeSwitches.ENABLE_NTP_SNIPPETS)) {
+        if (ChromeFeatureList.isEnabled("NTPSnippets")) {

[Bernhard Bauer, 2016/02/09 14:44:20]

It seems like this should also get extract to a string constant. Would it make
sense to move this to a class like ChromeFeatures?

[Marc Treib, 2016/02/10 11:18:40]

I've added a constant to the existing ChromeFeatureList class - that's what you
meant, right? (We *could* of course make a method to retrieve the actual string
from native instead of duplicating it, but that doesn't seem worth a
Java->native roundtrip - WDYT?)

[Bernhard Bauer, 2016/02/10 11:24:56]

Pretty much -- although I was more thinking of putting it into a separate class,
in the same way that CommandLine and ChromeSwitches are different classes. But
this is fine.
Yeah, I agree. If anything, we could look into automatically generating the Java
strings from the C++ strings, like we do for enums.

             mSearchProviderHasLogo = false;
             if (mNewTabPageView != null) mNewTabPageView.setSearchProviderHasLogo(false);
         } else {