examples/ui/noodles/noodles_app.h - Issue 1679023006: Reify view ownership as a message pipe.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: examples/ui/noodles/noodles_app.h

Issue 1679023006: Reify view ownership as a message pipe. (Closed) Base URL: git@github.com:domokit/mojo.git@master

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: examples/ui/noodles/noodles_app.h

diff --git a/examples/ui/noodles/noodles_app.h b/examples/ui/noodles/noodles_app.h

index 221cd8e9c211c9a065c02969649e74905a8c55f5..6556b2b531df52c8090a458ca4568e06ffb5012c 100644

--- a/examples/ui/noodles/noodles_app.h

+++ b/examples/ui/noodles/noodles_app.h

@@ -14,11 +14,11 @@ class NoodlesApp : public mojo::ui::ViewProviderApp {

NoodlesApp();

~NoodlesApp() override;

- bool CreateView(

+ void CreateView(

const std::string& connection_url,

+ mojo::InterfaceRequest<mojo::ui::ViewOwner> view_owner_request,

mojo::InterfaceRequest<mojo::ServiceProvider> services,

- mojo::ServiceProviderPtr exposed_services,

- const mojo::ui::ViewProvider::CreateViewCallback& callback) override;

+ mojo::ServiceProviderPtr exposed_services) override;

private:

DISALLOW_COPY_AND_ASSIGN(NoodlesApp);