Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(191)

Unified Diff: examples/ui/noodles/noodles_app.cc

Issue 1679023006: Reify view ownership as a message pipe. (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « examples/ui/noodles/noodles_app.h ('k') | examples/ui/noodles/noodles_view.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: examples/ui/noodles/noodles_app.cc
diff --git a/examples/ui/noodles/noodles_app.cc b/examples/ui/noodles/noodles_app.cc
index 31a3c4c6474eda8277b216c2a5b513a76ff3445f..4a6543d2bbd5faa9e5aa86f8980ea45165246825 100644
--- a/examples/ui/noodles/noodles_app.cc
+++ b/examples/ui/noodles/noodles_app.cc
@@ -12,13 +12,12 @@ NoodlesApp::NoodlesApp() {}
NoodlesApp::~NoodlesApp() {}
-bool NoodlesApp::CreateView(
+void NoodlesApp::CreateView(
const std::string& connection_url,
+ mojo::InterfaceRequest<mojo::ui::ViewOwner> view_owner_request,
mojo::InterfaceRequest<mojo::ServiceProvider> services,
- mojo::ServiceProviderPtr exposed_services,
- const mojo::ui::ViewProvider::CreateViewCallback& callback) {
- new NoodlesView(app_impl(), callback);
- return true;
+ mojo::ServiceProviderPtr exposed_services) {
+ new NoodlesView(app_impl(), view_owner_request.Pass());
}
} // namespace examples
« no previous file with comments | « examples/ui/noodles/noodles_app.h ('k') | examples/ui/noodles/noodles_view.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698