Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1017)

Issue 1678953004: [builtins] Remove bunch of uses of %_Arguments and %_ArgumentsLength. (Closed)

Created:
4 years, 10 months ago by Benedikt Meurer
Modified:
4 years, 10 months ago
Reviewers:
Yang
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[builtins] Remove bunch of uses of %_Arguments and %_ArgumentsLength. There are a bunch of places in our builtins where we use %_Arguments and %_ArgumentsLength for no good reason, as arguments object and/or rest parameter is as good and performant in these cases. Now the only uses of %_Arguments and %_ArgumentsLength left are in string.js, which requires dedicated investigation. CQ_INCLUDE_TRYBOTS=tryserver.v8:v8_linux_nosnap_dbg R=yangguo@chromium.org Committed: https://crrev.com/2160429fd458e3c095475e718c97f77ac90d906f Cr-Commit-Position: refs/heads/master@{#33834} Committed: https://crrev.com/f6db05660ee062964fd1af73383e05fe97295328 Cr-Commit-Position: refs/heads/master@{#33881}

Patch Set 1 #

Patch Set 2 : Fix #

Patch Set 3 : REBASE. Fix deoptimizer adapted arguments materialization for builtins. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -39 lines) Patch
M src/accessors.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/accessors.cc View 1 2 3 chunks +13 lines, -5 lines 0 comments Download
M src/debug/debug-evaluate.cc View 1 2 1 chunk +1 line, -2 lines 0 comments Download
M src/deoptimizer.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/js/array.js View 1 2 14 chunks +20 lines, -20 lines 0 comments Download
M src/js/json.js View 1 chunk +1 line, -1 line 0 comments Download
M src/js/spread.js View 1 chunk +2 lines, -2 lines 0 comments Download
M src/js/typedarray.js View 1 6 chunks +7 lines, -7 lines 0 comments Download

Messages

Total messages: 23 (11 generated)
Benedikt Meurer
4 years, 10 months ago (2016-02-09 06:03:31 UTC) #1
Benedikt Meurer
Hey Yang, The awfulness is almost done. Please take a look. Thanks, Benedikt
4 years, 10 months ago (2016-02-09 06:04:55 UTC) #2
Yang
On 2016/02/09 06:04:55, Benedikt Meurer wrote: > Hey Yang, > > The awfulness is almost ...
4 years, 10 months ago (2016-02-09 06:06:45 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1678953004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1678953004/1
4 years, 10 months ago (2016-02-09 06:10:12 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-09 07:17:22 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/2160429fd458e3c095475e718c97f77ac90d906f Cr-Commit-Position: refs/heads/master@{#33834}
4 years, 10 months ago (2016-02-09 07:18:01 UTC) #8
Benedikt Meurer
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/1677063005/ by bmeurer@chromium.org. ...
4 years, 10 months ago (2016-02-09 08:01:59 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1678953004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1678953004/20001
4 years, 10 months ago (2016-02-09 08:48:56 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux_nosnap_dbg on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_nosnap_dbg/builds/1352)
4 years, 10 months ago (2016-02-09 10:14:13 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1678953004/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1678953004/40001
4 years, 10 months ago (2016-02-11 06:32:27 UTC) #19
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 10 months ago (2016-02-11 07:12:59 UTC) #21
commit-bot: I haz the power
4 years, 10 months ago (2016-02-11 10:41:06 UTC) #23
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/f6db05660ee062964fd1af73383e05fe97295328
Cr-Commit-Position: refs/heads/master@{#33881}

Powered by Google App Engine
This is Rietveld 408576698