src/debug/debug-evaluate.cc - Issue 1678953004: [builtins] Remove bunch of uses of %_Arguments and %_ArgumentsLength.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/debug/debug-evaluate.cc

Issue 1678953004: [builtins] Remove bunch of uses of %_Arguments and %_ArgumentsLength. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: REBASE. Fix deoptimizer adapted arguments materialization for builtins. Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/debug/debug-evaluate.cc

diff --git a/src/debug/debug-evaluate.cc b/src/debug/debug-evaluate.cc

index c76112baffa0a491cbba67c1ccc556d5ef8e2cfe..25283d2ebd26e5e42c928436a4d4e38c1480ce13 100644

--- a/src/debug/debug-evaluate.cc

+++ b/src/debug/debug-evaluate.cc

@@ -302,8 +302,7 @@ void DebugEvaluate::ContextBuilder::MaterializeArgumentsObject(

if (maybe.FromJust()) return;

// FunctionGetArguments can't throw an exception.

- Handle<JSObject> arguments =

- Handle<JSObject>::cast(Accessors::FunctionGetArguments(function));

+ Handle<JSObject> arguments = Accessors::FunctionGetArguments(function);

Handle<String> arguments_str = isolate_->factory()->arguments_string();

JSObject::SetOwnPropertyIgnoreAttributes(target, arguments_str, arguments,

NONE)

« no previous file with comments | « src/accessors.cc ('k') | src/deoptimizer.cc » ('j') | no next file with comments »