msan: define BREAK_IF_DEBUGGING_AND_OUT_OF_RANGE in piex

msan: define BREAK_IF_DEBUGGING_AND_OUT_OF_RANGE in piex

This should assert(false) if we're in the error case of RangeCheckedBytePtr::extractBytes:

> #ifdef BREAK_IF_DEBUGGING_AND_OUT_OF_RANGE
>   #define BREAK_IF_DEBUGGING() assert(false)
> #else
>   #define BREAK_IF_DEBUGGING() assert(true)
> #endif
  ...
> std::vector<unsigned char> RangeCheckedBytePtr::extractBytes(size_t pos, size_t length) const {
>   std::vector<unsigned char> result;
>   if (pos + length < pos /* overflow */ || remainingLength() < pos + length) {
>     BREAK_IF_DEBUGGING();
>     error_flag_ = RANGE_CHECKED_BYTE_ERROR_OVERFLOW;
>     return result;
>   }
  ...

BUG=skia:4903
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1678913002

Committed: https://skia.googlesource.com/skia/+/6fd4e44e238755f8f81d007c8281c8fd63f03b3b

[mtklein_C, 2016-02-08 16:55:58]

Description was changed from

==========
msan: define BREAK_IF_DEBUGGING_AND_OUT_OF_RANGE in piex

This should assert(false) if we're in the error case of
RangeCheckedBytePtr::extractBytes:

> #ifdef BREAK_IF_DEBUGGING_AND_OUT_OF_RANGE
>   #define BREAK_IF_DEBUGGING() assert(false)
> #else
>   #define BREAK_IF_DEBUGGING() assert(true)
> #endif
  ...
> std::vector<unsigned char> RangeCheckedBytePtr::extractBytes(size_t pos,
size_t length) const {
>   std::vector<unsigned char> result;
>   if (pos + length < pos /* overflow */ || remainingLength() < pos + length) {
>     BREAK_IF_DEBUGGING();
>     error_flag_ = RANGE_CHECKED_BYTE_ERROR_OVERFLOW;
>     return result;
>   }
  ...

BUG=skia:4903
==========

to

==========
msan: define BREAK_IF_DEBUGGING_AND_OUT_OF_RANGE in piex

This should assert(false) if we're in the error case of
RangeCheckedBytePtr::extractBytes:

> #ifdef BREAK_IF_DEBUGGING_AND_OUT_OF_RANGE
>   #define BREAK_IF_DEBUGGING() assert(false)
> #else
>   #define BREAK_IF_DEBUGGING() assert(true)
> #endif
  ...
> std::vector<unsigned char> RangeCheckedBytePtr::extractBytes(size_t pos,
size_t length) const {
>   std::vector<unsigned char> result;
>   if (pos + length < pos /* overflow */ || remainingLength() < pos + length) {
>     BREAK_IF_DEBUGGING();
>     error_flag_ = RANGE_CHECKED_BYTE_ERROR_OVERFLOW;
>     return result;
>   }
  ...

BUG=skia:4903
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[mtklein_C, 2016-02-08 16:56:15]

mtklein@chromium.org changed reviewers:
+ msarett@google.com

[mtklein_C, 2016-02-08 16:56:15]

The CQ bit was checked by mtklein@chromium.org

[commit-bot: I haz the power, 2016-02-08 16:56:24]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1678913002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1678913002/1

[commit-bot: I haz the power, 2016-02-08 16:56:26]

Note for Reviewers:
The CQ is waiting for an approval.
If you believe that the CL is not ready yet, or if you would like to L-G-T-M
with comments then please uncheck the CQ checkbox.

Waiting for LGTM from valid reviewer(s) till 2016-02-08 22:56 UTC

[msarett, 2016-02-08 17:02:23]

https://codereview.chromium.org/1678913002/diff/1/gyp/piex.gyp
File gyp/piex.gyp (right):

https://codereview.chromium.org/1678913002/diff/1/gyp/piex.gyp#newcode38
gyp/piex.gyp:38: 'defines': [ 'BREAK_IF_DEBUGGING_AND_OUT_OF_RANGE' ],
Do we want to define this all the time or only in Debug mode?

[mtklein, 2016-02-08 17:22:24]

mtklein@google.com changed reviewers:
+ mtklein@google.com

[mtklein, 2016-02-08 17:22:24]

https://codereview.chromium.org/1678913002/diff/1/gyp/piex.gyp
File gyp/piex.gyp (right):

https://codereview.chromium.org/1678913002/diff/1/gyp/piex.gyp#newcode38
gyp/piex.gyp:38: 'defines': [ 'BREAK_IF_DEBUGGING_AND_OUT_OF_RANGE' ],
On 2016/02/08 17:02:23, msarett wrote:
> Do we want to define this all the time or only in Debug mode?

Doesn't matter.  It only affects debug mode.

[mtklein_C, 2016-02-08 17:22:36]

The CQ bit was unchecked by mtklein@chromium.org

[msarett, 2016-02-08 17:23:15]

lgtm

[mtklein_C, 2016-02-08 17:32:20]

Looks like we can rule this out as an explanation.  Nice to have that there
anyway.

[mtklein_C, 2016-02-08 17:34:13]

The CQ bit was checked by mtklein@chromium.org

[commit-bot: I haz the power, 2016-02-08 17:34:21]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1678913002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1678913002/1

[commit-bot: I haz the power, 2016-02-08 17:35:07]

Description was changed from

==========
msan: define BREAK_IF_DEBUGGING_AND_OUT_OF_RANGE in piex

This should assert(false) if we're in the error case of
RangeCheckedBytePtr::extractBytes:

> #ifdef BREAK_IF_DEBUGGING_AND_OUT_OF_RANGE
>   #define BREAK_IF_DEBUGGING() assert(false)
> #else
>   #define BREAK_IF_DEBUGGING() assert(true)
> #endif
  ...
> std::vector<unsigned char> RangeCheckedBytePtr::extractBytes(size_t pos,
size_t length) const {
>   std::vector<unsigned char> result;
>   if (pos + length < pos /* overflow */ || remainingLength() < pos + length) {
>     BREAK_IF_DEBUGGING();
>     error_flag_ = RANGE_CHECKED_BYTE_ERROR_OVERFLOW;
>     return result;
>   }
  ...

BUG=skia:4903
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
msan: define BREAK_IF_DEBUGGING_AND_OUT_OF_RANGE in piex

This should assert(false) if we're in the error case of
RangeCheckedBytePtr::extractBytes:

> #ifdef BREAK_IF_DEBUGGING_AND_OUT_OF_RANGE
>   #define BREAK_IF_DEBUGGING() assert(false)
> #else
>   #define BREAK_IF_DEBUGGING() assert(true)
> #endif
  ...
> std::vector<unsigned char> RangeCheckedBytePtr::extractBytes(size_t pos,
size_t length) const {
>   std::vector<unsigned char> result;
>   if (pos + length < pos /* overflow */ || remainingLength() < pos + length) {
>     BREAK_IF_DEBUGGING();
>     error_flag_ = RANGE_CHECKED_BYTE_ERROR_OVERFLOW;
>     return result;
>   }
  ...

BUG=skia:4903
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/6fd4e44e238755f8f81d007c8281c8fd63f03b3b
==========

[commit-bot: I haz the power, 2016-02-08 17:35:08]

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/6fd4e44e238755f8f81d007c8281c8fd63f03b3b