msan: define BREAK_IF_DEBUGGING_AND_OUT_OF_RANGE in piex

gyp/piex.gyp

 # Copyright 2016 Google Inc. All Rights Reserved.
 #
 # Licensed under the Apache License, Version 2.0 (the "License");
 # you may not use this file except in compliance with the License.
 # You may obtain a copy of the License at
 #
 #     http://www.apache.org/licenses/LICENSE-2.0
 #
 # Unless required by applicable law or agreed to in writing, software
 # distributed under the License is distributed on an "AS IS" BASIS,
@@ skipping 17 matching lines @@
   'target_name': 'piex',
   'type': 'static_library',
   'sources': [
     '../third_party/externals/piex/src/binary_parse/cached_paged_byte_array.cc',
     '../third_party/externals/piex/src/binary_parse/range_checked_byte_ptr.cc',
     '../third_party/externals/piex/src/image_type_recognition/image_type_recognition_lite.cc',
     '../third_party/externals/piex/src/piex.cc',
     '../third_party/externals/piex/src/tiff_directory/tiff_directory.cc',
     '../third_party/externals/piex/src/tiff_parser.cc',
   ],
+  'defines': [ 'BREAK_IF_DEBUGGING_AND_OUT_OF_RANGE' ],

[msarett, 2016/02/08 17:02:23]

Do we want to define this all the time or only in Debug mode?

[mtklein, 2016/02/08 17:22:24]

Doesn't matter.  It only affects debug mode.

   'include_dirs': [ '../third_party/externals/piex' ],
   'direct_dependent_settings': {
     'include_dirs': [ '../third_party/externals/piex' ],
   },
   'cflags': [ '-w' ],
   'msvs_settings': { 'VCCLCompilerTool': { 'WarningLevel': '0' } },
   'xcode_settings': { 'WARNING_CFLAGS': ['-w'] },
 }],
 }