Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2767)

Unified Diff: chrome/browser/sync/test/integration/sync_auth_test.cc

Issue 167873002: sync: Improve StatusChangeChecker debug strings (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/sync/test/integration/sync_auth_test.cc
diff --git a/chrome/browser/sync/test/integration/sync_auth_test.cc b/chrome/browser/sync/test/integration/sync_auth_test.cc
index a943a9463206714636cebfec476d75bc8a66c0fd..1ceb2d6749efdd8a19ccb771fea0a334788c3b5d 100644
--- a/chrome/browser/sync/test/integration/sync_auth_test.cc
+++ b/chrome/browser/sync/test/integration/sync_auth_test.cc
@@ -50,13 +50,14 @@ class TestForAuthError : public StatusChangeChecker {
explicit TestForAuthError(ProfileSyncService* service);
virtual ~TestForAuthError();
virtual bool IsExitConditionSatisfied() OVERRIDE;
+ virtual std::string GetDebugMessage() const OVERRIDE;
private:
ProfileSyncService* service_;
};
TestForAuthError::TestForAuthError(ProfileSyncService* service)
- : StatusChangeChecker("Testing for auth error"), service_(service) {}
+ : service_(service) {}
TestForAuthError::~TestForAuthError() {}
@@ -66,6 +67,10 @@ bool TestForAuthError::IsExitConditionSatisfied() {
GoogleServiceAuthError::NONE);
}
+std::string TestForAuthError::GetDebugMessage() const {
+ return "Waiting for auth error";
+}
+
class SyncAuthTest : public SyncTest {
public:
SyncAuthTest() : SyncTest(SINGLE_CLIENT), bookmark_index_(0) {}
@@ -82,7 +87,7 @@ class SyncAuthTest : public SyncTest {
// Run until the bookmark is committed or an auth error is encountered.
TestForAuthError checker_(GetClient(0)->service());
- GetClient(0)->AwaitStatusChange(&checker_, "Attempt to trigger auth error");
+ GetClient(0)->AwaitStatusChange(&checker_);
GoogleServiceAuthError oauth_error =
GetClient(0)->service()->GetSyncTokenStatus().last_get_token_error;

Powered by Google App Engine
This is Rietveld 408576698