Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 1678613002: Revert of Separate out resource mailbox creation and fix synchronization issue. (Closed)

Created:
4 years, 10 months ago by David Yen
Modified:
4 years, 10 months ago
Reviewers:
reveman, piman
CC:
cc-bugs_chromium.org, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Separate out resource mailbox creation and fix synchronization issue. (patchset #3 id:40001 of https://codereview.chromium.org/1666203003/ ) Reason for revert: Causing renderer synchronization issues Original issue's description: > Separate out resource mailbox creation and fix synchronization issue. > > The resource transfer function has been split up so it does the lazy > resource mailbox creation in a separate pass. This allows us to setup > the sync token directly on the resource itself before the transfer. > > The texture binding code is also done on the first pass, this fixes > a subtle synchronization issue where previously the bound textures > could potentially not have a sync token attached to it if no mailboxes > were lazily created. > > BUG=584381 > CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel > > Committed: https://crrev.com/d5650cab68401bcd2bb89e1a98c65378d493f785 > Cr-Commit-Position: refs/heads/master@{#373847} TBR=reveman@chromium.org,piman@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=584381, 584780 Committed: https://crrev.com/a14747b0409da6ca3700c03a0a4e5cb28de9f3b0 Cr-Commit-Position: refs/heads/master@{#373974}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -80 lines) Patch
M cc/resources/resource_provider.h View 1 chunk +0 lines, -6 lines 0 comments Download
M cc/resources/resource_provider.cc View 4 chunks +56 lines, -71 lines 0 comments Download
M cc/resources/resource_provider_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M cc/resources/texture_mailbox.h View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
David Yen
Created Revert of Separate out resource mailbox creation and fix synchronization issue.
4 years, 10 months ago (2016-02-06 00:41:10 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1678613002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1678613002/1
4 years, 10 months ago (2016-02-06 00:41:28 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-06 00:44:11 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/a14747b0409da6ca3700c03a0a4e5cb28de9f3b0 Cr-Commit-Position: refs/heads/master@{#373974}
4 years, 10 months ago (2016-02-06 00:45:30 UTC) #7
David Yen
4 years, 10 months ago (2016-02-08 18:28:30 UTC) #8
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1674313002/ by dyen@chromium.org.

The reason for reverting is: Trying to reland patch with fixes..

Powered by Google App Engine
This is Rietveld 408576698