Subzero: Fix a mul lowering error.

Subzero: Fix a mul lowering error.

The low-level mul instruction may produce results in a register pair where one register is the explicit dest of the instruction, and the other register is defined through a FakeDef.  If the FakeDef portion is ultimately unused, the FakeDef gets dead-code eliminated, and the register allocator doesn't know that the mul instruction affects the other register.

On x86, this can silently produce incorrect code.  On ARM, the emitter complains that the explicitly represented second dest variable does not have a register.

The fix is to add a FakeUse of the FakeDef'd register.  Unfortunately, this prevents the low-level mul instruction from ever being dead-code eliminated, but that's probably OK because it should have been eliminated at the high level.

BUG= none
R=eholk@chromium.org

Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=28df6bad8e70d9930040464791296e192aaa03ef

[Jim Stichnoth, 2016-02-05 23:23:47]

Description was changed from

==========
Subzero: Fix a mul lowering error.

BUG= none
==========

to

==========
Subzero: Fix a mul lowering error.

The low-level mul instruction may produce results in a register pair where one
register is the explicit dest of the instruction, and the other register is
defined through a FakeDef.  If the FakeDef portion is ultimately unused, the
FakeDef gets dead-code eliminated, and the register allocator doesn't know that
the mul instruction affects the other register.

On x86, this can silently produce incorrect code.  On ARM, the emitter complains
that the explicitly represented second dest variable does not have a register.

The fix is to add a FakeUse of the FakeDef'd register.  Unfortunately, this
prevents the low-level mul instruction from ever being dead-code eliminated, but
that's probably OK because it should have been eliminated at the high level.

BUG= none
==========

[Jim Stichnoth, 2016-02-05 23:23:47]

stichnot@chromium.org changed reviewers:
+ eholk@chromium.org, jpp@chromium.org, kschimpf@google.com, sehr@chromium.org

[Eric Holk, 2016-02-05 23:33:28]

lgtm

[Jim Stichnoth, 2016-02-05 23:43:27]

Description was changed from

==========
Subzero: Fix a mul lowering error.

The low-level mul instruction may produce results in a register pair where one
register is the explicit dest of the instruction, and the other register is
defined through a FakeDef.  If the FakeDef portion is ultimately unused, the
FakeDef gets dead-code eliminated, and the register allocator doesn't know that
the mul instruction affects the other register.

On x86, this can silently produce incorrect code.  On ARM, the emitter complains
that the explicitly represented second dest variable does not have a register.

The fix is to add a FakeUse of the FakeDef'd register.  Unfortunately, this
prevents the low-level mul instruction from ever being dead-code eliminated, but
that's probably OK because it should have been eliminated at the high level.

BUG= none
==========

to

==========
Subzero: Fix a mul lowering error.

The low-level mul instruction may produce results in a register pair where one
register is the explicit dest of the instruction, and the other register is
defined through a FakeDef.  If the FakeDef portion is ultimately unused, the
FakeDef gets dead-code eliminated, and the register allocator doesn't know that
the mul instruction affects the other register.

On x86, this can silently produce incorrect code.  On ARM, the emitter complains
that the explicitly represented second dest variable does not have a register.

The fix is to add a FakeUse of the FakeDef'd register.  Unfortunately, this
prevents the low-level mul instruction from ever being dead-code eliminated, but
that's probably OK because it should have been eliminated at the high level.

BUG= none
R=eholk@chromium.org

Committed:
https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a...
==========

[Jim Stichnoth, 2016-02-05 23:43:29]

Committed patchset #1 (id:1) manually as
28df6bad8e70d9930040464791296e192aaa03ef (presubmit successful).