Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Side by Side Diff: tests_lit/llvm2ice_tests/multidef_kill.ll

Issue 1678523002: Subzero: Fix a mul lowering error. (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/IceTargetLoweringX86BaseImpl.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
(Empty)
1 ; This tests against a lowering error in a multiply instruction that produces
2 ; results in a low and high register. This is usually lowered as a mul
3 ; instruction whose dest contains the low portion, and a FakeDef of the high
4 ; portion. The problem is that if the high portion is unused (e.g. the multiply
5 ; is followed by a truncation), the FakeDef may be eliminated, and the register
6 ; allocator may assign the high register to a variable that is live across the
7 ; mul instruction. This is incorrect because the mul instruction smashes the
8 ; register.
9
10 ; REQUIRES: allow_dump
11
12 ; RUN: %p2i --target x8632 -i %s --filetype=asm --args -O2 -asm-verbose \
13 ; RUN: --reg-use=eax,edx -reg-reserve | FileCheck --check-prefix=X8632 %s
14 ; RUN: %p2i --target arm32 -i %s --filetype=asm --args -O2 -asm-verbose \
15 ; RUN: | FileCheck --check-prefix=ARM32 %s
16
17 define internal i32 @mul(i64 %a, i64 %b, i32 %c) {
18 ; Force an early use of %c.
19 store i32 %c, i32* undef, align 1
20 %m = mul i64 %a, %b
21 %t = trunc i64 %m to i32
22 ; Make many uses of %c to give it high weight.
23 %t1 = add i32 %t, %c
24 %t2 = add i32 %t1, %c
25 %t3 = add i32 %t2, %c
26 ret i32 %t3
27 }
28
29 ; For x8632, we want asm-verbose to print the stack offset assignment for lv$c
30 ; ("local variable 'c'") in the prolog, and then have at least one use of lv$c
31 ; in the body, i.e. don't register-allocate edx to %c.
32
33 ; X8632-LABEL: mul
34 ; X8632: lv$c =
35 ; X8632: lv$c
36
37 ; For arm32, the failure would manifest as a translation error - no register
38 ; being allocated to the high operand, so we just check for successful
39 ; translation.
40
41 ; ARM32-LABEL: mul
OLDNEW
« no previous file with comments | « src/IceTargetLoweringX86BaseImpl.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698