Remove more feature in product mode

Remove more feature in product mode

- Remove Timeline.
- Remove more vmservice code.
- Remove AST printing.
- Remove IL printing.
- Remove profiler.
- Remove thread interrupter.
- Remove disassembler.
- Remove Library::CheckFunctionFingerprints.

- Update test status files for product mode.

Size of dart_bootstrap before: 5287631
Size of dart_bootstrap after: 5112783

Reduction in size: 174848 bytes.

Total reduction in size (382734 + 174848): 557582 bytes.

R=rmacnak@google.com

Committed: https://github.com/dart-lang/sdk/commit/e2e7af1229a02757af0b40ecd14b82b93c3f1288

[Cutch, 2016-02-08 21:09:32]

Description was changed from

==========
Remove more in product mode
==========

to

==========
Remove more feature in product mode

- Remove Timeline.
- Remove more vmservice code.
- Remove AST printing.
- Remove IL printing.
- Remove profiler.
- Remove thread interrupter.
- Remove disassembler.
- Remove Library::CheckFunctionFingerprints.

- Update test status files for product mode.
==========

[Cutch, 2016-02-08 21:09:32]

johnmccutchan@google.com changed reviewers:
+ rmacnak@google.com

[Cutch, 2016-02-08 21:16:13]

Description was changed from

==========
Remove more feature in product mode

- Remove Timeline.
- Remove more vmservice code.
- Remove AST printing.
- Remove IL printing.
- Remove profiler.
- Remove thread interrupter.
- Remove disassembler.
- Remove Library::CheckFunctionFingerprints.

- Update test status files for product mode.
==========

to

==========
Remove more feature in product mode

- Remove Timeline.
- Remove more vmservice code.
- Remove AST printing.
- Remove IL printing.
- Remove profiler.
- Remove thread interrupter.
- Remove disassembler.
- Remove Library::CheckFunctionFingerprints.

- Update test status files for product mode.

Size of dart_bootstrap before: 5287631
Size of dart_bootstrap after: 5112783

Reduction in size: 174848 bytes.

Total reduction in size (382734 + 174848): 557582 bytes.
==========

[rmacnak, 2016-02-08 22:42:36]

https://chromiumcodereview.appspot.com/1678203002/diff/20001/runtime/vm/ast_p...
File runtime/vm/ast_printer_test.cc (right):

https://chromiumcodereview.appspot.com/1678203002/diff/20001/runtime/vm/ast_p...
runtime/vm/ast_printer_test.cc:41: #endif
// !PRODUCT

https://chromiumcodereview.appspot.com/1678203002/diff/20001/runtime/vm/flag_...
File runtime/vm/flag_list.h (right):

https://chromiumcodereview.appspot.com/1678203002/diff/20001/runtime/vm/flag_...
runtime/vm/flag_list.h:38: "Support the profiler.")                             
                       \
Enable the profiler

https://chromiumcodereview.appspot.com/1678203002/diff/20001/runtime/vm/flag_...
runtime/vm/flag_list.h:52: "Support timeline.")                                 
                       \
For each support_*, how about a sanity hello world test that disables it at
runtime? (Like standalone/no_lazy_dispatchers).

https://chromiumcodereview.appspot.com/1678203002/diff/20001/runtime/vm/flow_...
File runtime/vm/flow_graph_compiler.cc (right):

https://chromiumcodereview.appspot.com/1678203002/diff/20001/runtime/vm/flow_...
runtime/vm/flow_graph_compiler.cc:1286: if (!FLAG_support_il_printer) {
+ support_disassembler

https://chromiumcodereview.appspot.com/1678203002/diff/20001/runtime/vm/flow_...
File runtime/vm/flow_graph_range_analysis_test.cc (right):

https://chromiumcodereview.appspot.com/1678203002/diff/20001/runtime/vm/flow_...
runtime/vm/flow_graph_range_analysis_test.cc:10: #ifndef PRODUCT
Let's exclude just the prints.

https://chromiumcodereview.appspot.com/1678203002/diff/20001/runtime/vm/il_pr...
File runtime/vm/il_printer.cc (right):

https://chromiumcodereview.appspot.com/1678203002/diff/20001/runtime/vm/il_pr...
runtime/vm/il_printer.cc:1222: #else
// PRODUCT

https://chromiumcodereview.appspot.com/1678203002/diff/20001/runtime/vm/il_pr...
runtime/vm/il_printer.cc:1225: bool print_locations) {
UNREACHABLE()

[Cutch, 2016-02-08 23:07:56]

https://codereview.chromium.org/1678203002/diff/20001/runtime/vm/ast_printer_...
File runtime/vm/ast_printer_test.cc (right):

https://codereview.chromium.org/1678203002/diff/20001/runtime/vm/ast_printer_...
runtime/vm/ast_printer_test.cc:41: #endif
On 2016/02/08 22:42:36, rmacnak wrote:
> // !PRODUCT

Done.

https://codereview.chromium.org/1678203002/diff/20001/runtime/vm/flag_list.h
File runtime/vm/flag_list.h (right):

https://codereview.chromium.org/1678203002/diff/20001/runtime/vm/flag_list.h#...
runtime/vm/flag_list.h:38: "Support the profiler.")                             
                       \
On 2016/02/08 22:42:36, rmacnak wrote:
> Enable the profiler

Done.

https://codereview.chromium.org/1678203002/diff/20001/runtime/vm/flag_list.h#...
runtime/vm/flag_list.h:52: "Support timeline.")                                 
                       \
On 2016/02/08 22:42:36, rmacnak wrote:
> For each support_*, how about a sanity hello world test that disables it at
> runtime? (Like standalone/no_lazy_dispatchers).

Done.

https://codereview.chromium.org/1678203002/diff/20001/runtime/vm/flow_graph_c...
File runtime/vm/flow_graph_compiler.cc (right):

https://codereview.chromium.org/1678203002/diff/20001/runtime/vm/flow_graph_c...
runtime/vm/flow_graph_compiler.cc:1286: if (!FLAG_support_il_printer) {
On 2016/02/08 22:42:36, rmacnak wrote:
> + support_disassembler

Done.

https://codereview.chromium.org/1678203002/diff/20001/runtime/vm/flow_graph_r...
File runtime/vm/flow_graph_range_analysis_test.cc (right):

https://codereview.chromium.org/1678203002/diff/20001/runtime/vm/flow_graph_r...
runtime/vm/flow_graph_range_analysis_test.cc:10: #ifndef PRODUCT
On 2016/02/08 22:42:36, rmacnak wrote:
> Let's exclude just the prints.

Done.

https://codereview.chromium.org/1678203002/diff/20001/runtime/vm/il_printer.cc
File runtime/vm/il_printer.cc (right):

https://codereview.chromium.org/1678203002/diff/20001/runtime/vm/il_printer.c...
runtime/vm/il_printer.cc:1222: #else
On 2016/02/08 22:42:36, rmacnak wrote:
> // PRODUCT

Done.

https://codereview.chromium.org/1678203002/diff/20001/runtime/vm/il_printer.c...
runtime/vm/il_printer.cc:1225: bool print_locations) {
On 2016/02/08 22:42:36, rmacnak wrote:
> UNREACHABLE()

Done.

[rmacnak, 2016-02-08 23:24:17]

lgtm

https://chromiumcodereview.appspot.com/1678203002/diff/2/tests/standalone/no_...
File tests/standalone/no_profiler_test.dart (right):

https://chromiumcodereview.appspot.com/1678203002/diff/2/tests/standalone/no_...
tests/standalone/no_profiler_test.dart:5: // VMOptions=--no_profiler
You probably also need to skip these in product mode because the flag isn't
settable then.

[Cutch, 2016-02-08 23:30:43]

https://codereview.chromium.org/1678203002/diff/2/tests/standalone/no_profile...
File tests/standalone/no_profiler_test.dart (right):

https://codereview.chromium.org/1678203002/diff/2/tests/standalone/no_profile...
tests/standalone/no_profiler_test.dart:5: // VMOptions=--no_profiler
On 2016/02/08 23:24:17, rmacnak wrote:
> You probably also need to skip these in product mode because the flag isn't
> settable then.

Done.

[Cutch, 2016-02-09 16:45:36]

Description was changed from

==========
Remove more feature in product mode

- Remove Timeline.
- Remove more vmservice code.
- Remove AST printing.
- Remove IL printing.
- Remove profiler.
- Remove thread interrupter.
- Remove disassembler.
- Remove Library::CheckFunctionFingerprints.

- Update test status files for product mode.

Size of dart_bootstrap before: 5287631
Size of dart_bootstrap after: 5112783

Reduction in size: 174848 bytes.

Total reduction in size (382734 + 174848): 557582 bytes.
==========

to

==========
Remove more feature in product mode

- Remove Timeline.
- Remove more vmservice code.
- Remove AST printing.
- Remove IL printing.
- Remove profiler.
- Remove thread interrupter.
- Remove disassembler.
- Remove Library::CheckFunctionFingerprints.

- Update test status files for product mode.

Size of dart_bootstrap before: 5287631
Size of dart_bootstrap after: 5112783

Reduction in size: 174848 bytes.

Total reduction in size (382734 + 174848): 557582 bytes.

R=rmacnak@google.com

Committed:
https://github.com/dart-lang/sdk/commit/e2e7af1229a02757af0b40ecd14b82b93c3f1288
==========

[Cutch, 2016-02-09 16:45:40]

Committed patchset #6 (id:80001) manually as
e2e7af1229a02757af0b40ecd14b82b93c3f1288 (presubmit successful).