Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(208)

Unified Diff: runtime/vm/dart.cc

Issue 1678203002: Remove more feature in product mode (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/compiler.cc ('k') | runtime/vm/dart_api_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/dart.cc
diff --git a/runtime/vm/dart.cc b/runtime/vm/dart.cc
index 02ec984a5eddebe3e6313718065ab852264445c2..bace9af3c1dc0cd73342a5721d1c45dcc35751e1 100644
--- a/runtime/vm/dart.cc
+++ b/runtime/vm/dart.cc
@@ -92,16 +92,22 @@ const char* Dart::InitOnce(const uint8_t* vm_isolate_snapshot,
OS::InitOnce();
VirtualMemory::InitOnce();
OSThread::InitOnce();
- Timeline::InitOnce();
+ if (FLAG_support_timeline) {
+ Timeline::InitOnce();
+ }
+#ifndef PRODUCT
TimelineDurationScope tds(Timeline::GetVMStream(),
"Dart::InitOnce");
+#endif
Isolate::InitOnce();
PortMap::InitOnce();
FreeListElement::InitOnce();
Api::InitOnce();
CodeObservers::InitOnce();
- ThreadInterrupter::InitOnce();
- Profiler::InitOnce();
+ if (FLAG_profiler) {
+ ThreadInterrupter::InitOnce();
+ Profiler::InitOnce();
+ }
SemiSpace::InitOnce();
Metric::InitOnce();
StoreBuffer::InitOnce();
@@ -228,8 +234,11 @@ const char* Dart::Cleanup() {
return "VM already terminated.";
}
- // Shut down profiling.
- Profiler::Shutdown();
+ if (FLAG_profiler) {
+ // Shut down profiling.
+ Profiler::Shutdown();
+ }
+
{
// Set the VM isolate as current isolate when shutting down
@@ -292,7 +301,9 @@ const char* Dart::Cleanup() {
}
CodeObservers::DeleteAll();
- Timeline::Shutdown();
+ if (FLAG_support_timeline) {
+ Timeline::Shutdown();
+ }
return NULL;
}
@@ -310,15 +321,18 @@ RawError* Dart::InitializeIsolate(const uint8_t* snapshot_buffer, void* data) {
// Initialize the new isolate.
Thread* T = Thread::Current();
Isolate* I = T->isolate();
+#ifndef PRODUCT
TimelineDurationScope tds(T, I->GetIsolateStream(), "InitializeIsolate");
tds.SetNumArguments(1);
tds.CopyArgument(0, "isolateName", I->name());
-
+#endif // !PRODUCT
ASSERT(I != NULL);
StackZone zone(T);
HandleScope handle_scope(T);
{
+#ifndef PRODUCT
TimelineDurationScope tds(T, I->GetIsolateStream(), "ObjectStore::Init");
+#endif // !PRODUCT
ObjectStore::Init(I);
}
@@ -328,8 +342,10 @@ RawError* Dart::InitializeIsolate(const uint8_t* snapshot_buffer, void* data) {
}
if (snapshot_buffer != NULL) {
// Read the snapshot and setup the initial state.
+#ifndef PRODUCT
TimelineDurationScope tds(
T, I->GetIsolateStream(), "IsolateSnapshotReader");
+#endif // !PRODUCT
// TODO(turnidge): Remove once length is not part of the snapshot.
const Snapshot* snapshot = Snapshot::SetupFromBuffer(snapshot_buffer);
if (snapshot == NULL) {
@@ -367,7 +383,9 @@ RawError* Dart::InitializeIsolate(const uint8_t* snapshot_buffer, void* data) {
#endif
{
+#ifndef PRODUCT
TimelineDurationScope tds(T, I->GetIsolateStream(), "StubCode::Init");
+#endif // !PRODUCT
StubCode::Init(I);
}
« no previous file with comments | « runtime/vm/compiler.cc ('k') | runtime/vm/dart_api_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698