mac_views_browser: fixed interactive_ui_tests compilation.

mac_views_browser: fixed interactive_ui_tests compilation.

Splitting interactive_test_utils_mac.mm to
mac specific part - interactive_test_utils_mac.mm
and cocoa-views part - interactive_test_utils_cocoa.mm.

Splitting interactive_test_utils_views.cc to
interactive_test_utils_common_views.cc that can be used in mac tests
and interactive_test_utils_views.cc that used only in toolkit-views tests.

Disabled 3 tests files that are not ready for mac_views.

BUG=575036
COLLABORATOR=kirr@yandex-team.ru
Also reviewed in http://crrev.com/1669793002/

Committed: https://crrev.com/21b504032d9dcf75db5048eb48ef50204ae45b90
Cr-Commit-Position: refs/heads/master@{#374640}

[themblsha, 2016-02-08 17:07:03]

Description was changed from

==========
mac_views_browser: fixed interactive_ui_tests compilation.

Splitting interactive_test_utils_mac.mm to
mac specific part - interactive_test_utils_mac.mm
and cocoa-views part - interactive_test_utils_cocoa.mm.

Splitting interactive_test_utils_views.cc to
interactive_test_utils_common_views.cc that can be used in mac tests
and interactive_test_utils_views.cc that used only in toolkit-views tests.

Disabled 3 tests files that are not ready for mac_views.

BUG=575036
==========

to

==========
mac_views_browser: fixed interactive_ui_tests compilation.

Splitting interactive_test_utils_mac.mm to
mac specific part - interactive_test_utils_mac.mm
and cocoa-views part - interactive_test_utils_cocoa.mm.

Splitting interactive_test_utils_views.cc to
interactive_test_utils_common_views.cc that can be used in mac tests
and interactive_test_utils_views.cc that used only in toolkit-views tests.

Disabled 3 tests files that are not ready for mac_views.

BUG=575036
==========

[themblsha, 2016-02-08 17:07:03]

mblsha@yandex-team.ru changed reviewers:
+ tapted@chromium.org

[themblsha, 2016-02-08 17:09:31]

On 2016/02/08 17:07:03, themblsha wrote:
> mailto:mblsha@yandex-team.ru changed reviewers:
> + mailto:tapted@chromium.org

Original CL by kirr: https://codereview.chromium.org/1669793002/ (he's on
vacation and asked me to fix remaining nits)

[tapted, 2016-02-09 06:13:28]

The CQ bit was checked by tapted@chromium.org

[tapted, 2016-02-09 06:13:33]

The CQ bit was unchecked by tapted@chromium.org

[tapted, 2016-02-09 06:13:39]

The CQ bit was checked by tapted@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-02-09 06:13:53]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1678163002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1678163002/1

[tapted, 2016-02-09 06:19:03]

lgtm, but can you add a note to the CL description, something to potentially
help later crawls through the git history. Like,

COLLABORATOR=kirr@yandex-team.ru
Also reviewed in http://crrev.com/1669793002/



(In the past, adding COLLABORATOR= to a CL description would actually let the
named user upload new patchsets, but I think that function got turned off at
some point).

I've also fired off a CQ Dry Run - sometimes this picks up issues like signing
contributor agreements, in case you haven't committed chrome code before.

You'll also need owners for review - probably sky@ is appropriate since he is in
chrome/test and chrome/browser

[commit-bot: I haz the power, 2016-02-09 06:36:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-09 06:36:58]

Dry run: Try jobs failed on following builders:
  linux_chromium_compile_dbg_32_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_compile_dbg_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[tapted, 2016-02-09 06:49:26]

Looks like there might be a conflict with a CL that just landed in r374245  ->
https://codereview.chromium.org/1671323002

so it will need a rebase, and an update to
ToolbarActionViewInteractiveUITest.MAYBE_ActivateOverflowedToolbarActionWithKeyboard

[themblsha, 2016-02-09 11:12:17]

On 2016/02/09 06:49:26, tapted wrote:
> Looks like there might be a conflict with a CL that just landed in r374245  ->
> https://codereview.chromium.org/1671323002
> 
> so it will need a rebase, and an update to
>
ToolbarActionViewInteractiveUITest.MAYBE_ActivateOverflowedToolbarActionWithKeyboard

Done. But when running locally these three tests time out for me:

3 tests timed out:
    ToolbarActionViewInteractiveUITest.DoubleClickToolbarActionToClose
(../../chrome/browser/ui/views/toolbar/toolbar_action_view_interactive_uitest.cc:306)
    ToolbarActionViewInteractiveUITest.TestClickingOnOverflowedAction
(../../chrome/browser/ui/views/toolbar/toolbar_action_view_interactive_uitest.cc:201)
    ToolbarActionViewInteractiveUITest.TestContextMenuOnOverflowedAction
(../../chrome/browser/ui/views/toolbar/toolbar_action_view_interactive_uitest.cc:243)

[themblsha, 2016-02-09 11:12:42]

mblsha@yandex-team.ru changed reviewers:
+ sky@chromium.org

[themblsha, 2016-02-09 11:17:22]

Description was changed from

==========
mac_views_browser: fixed interactive_ui_tests compilation.

Splitting interactive_test_utils_mac.mm to
mac specific part - interactive_test_utils_mac.mm
and cocoa-views part - interactive_test_utils_cocoa.mm.

Splitting interactive_test_utils_views.cc to
interactive_test_utils_common_views.cc that can be used in mac tests
and interactive_test_utils_views.cc that used only in toolkit-views tests.

Disabled 3 tests files that are not ready for mac_views.

BUG=575036
==========

to

==========
mac_views_browser: fixed interactive_ui_tests compilation.

Splitting interactive_test_utils_mac.mm to
mac specific part - interactive_test_utils_mac.mm
and cocoa-views part - interactive_test_utils_cocoa.mm.

Splitting interactive_test_utils_views.cc to
interactive_test_utils_common_views.cc that can be used in mac tests
and interactive_test_utils_views.cc that used only in toolkit-views tests.

Disabled 3 tests files that are not ready for mac_views.

BUG=575036
COLLABORATOR=kirr@yandex-team.ru
Also reviewed in http://crrev.com/1669793002/
==========

[tapted, 2016-02-09 22:06:07]

lgtm with the following changes. (I'll send off another CQ dry run too.)

https://codereview.chromium.org/1678163002/diff/20001/chrome/browser/ui/views...
File chrome/browser/ui/views/toolbar/toolbar_action_view_interactive_uitest.cc
(right):

https://codereview.chromium.org/1678163002/diff/20001/chrome/browser/ui/views...
chrome/browser/ui/views/toolbar/toolbar_action_view_interactive_uitest.cc:364:
#if defined(USE_OZONE) || defined(OS_MACOSX)
Can you undo this bit? There shouldn't be a need for the ||defined(OS_MACOSX)
yet. At this stage we are just looking for compile regressions in the
mac_views_browser=1 build so we can bring up a buildbot. This test won't be run
by default yet, and there's likely a few systemic problems that will fix a bunch
of tests in one go.

https://codereview.chromium.org/1678163002/diff/20001/chrome/browser/ui/views...
File chrome/browser/ui/views/toolbar/toolbar_view_interactive_uitest.cc (right):

https://codereview.chromium.org/1678163002/diff/20001/chrome/browser/ui/views...
chrome/browser/ui/views/toolbar/toolbar_view_interactive_uitest.cc:13: #include
"chrome/browser/ui/views/tabs/tab_drag_controller_interactive_uitest.h"
nit: Sorry - I missed this earlier, but this #include might be able to be
removed now that GetCenterInScreenCoordinates comes from
interactive_test_utils.h rather than an unrelated test harness' header

[tapted, 2016-02-09 22:07:09]

The CQ bit was checked by tapted@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-02-09 22:08:45]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1678163002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1678163002/20001

[sky, 2016-02-09 22:36:34]

LGTM

[commit-bot: I haz the power, 2016-02-09 23:18:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-09 23:18:47]

Dry run: This issue passed the CQ dry run.

[themblsha, 2016-02-10 10:28:31]

https://codereview.chromium.org/1678163002/diff/20001/chrome/browser/ui/views...
File chrome/browser/ui/views/toolbar/toolbar_action_view_interactive_uitest.cc
(right):

https://codereview.chromium.org/1678163002/diff/20001/chrome/browser/ui/views...
chrome/browser/ui/views/toolbar/toolbar_action_view_interactive_uitest.cc:364:
#if defined(USE_OZONE) || defined(OS_MACOSX)
On 2016/02/09 22:06:07, tapted wrote:
> Can you undo this bit? There shouldn't be a need for the ||defined(OS_MACOSX)
> yet. At this stage we are just looking for compile regressions in the
> mac_views_browser=1 build so we can bring up a buildbot. This test won't be
run
> by default yet, and there's likely a few systemic problems that will fix a
bunch
> of tests in one go.

Okay. It compiled (I replaced test:: with ui_test_utils::), but I only tested on
a Mac. And it crashed when I tried running it. Will remove OS_MACOSX now.

https://codereview.chromium.org/1678163002/diff/20001/chrome/browser/ui/views...
File chrome/browser/ui/views/toolbar/toolbar_view_interactive_uitest.cc (right):

https://codereview.chromium.org/1678163002/diff/20001/chrome/browser/ui/views...
chrome/browser/ui/views/toolbar/toolbar_view_interactive_uitest.cc:13: #include
"chrome/browser/ui/views/tabs/tab_drag_controller_interactive_uitest.h"
On 2016/02/09 22:06:07, tapted wrote:
> nit: Sorry - I missed this earlier, but this #include might be able to be
> removed now that GetCenterInScreenCoordinates comes from
> interactive_test_utils.h rather than an unrelated test harness' header

Yep, compiles just fine.

[themblsha, 2016-02-10 10:37:58]

The CQ bit was checked by mblsha@yandex-team.ru

[themblsha, 2016-02-10 10:37:58]

The patchset sent to the CQ was uploaded after l-g-t-m from tapted@chromium.org,
sky@chromium.org
Link to the patchset: https://codereview.chromium.org/1678163002/#ps40001
(title: "Removed unneeded header, enable
ActivateOverflowedToolbarActionWithKeyboard test compilation on Mac")

[commit-bot: I haz the power, 2016-02-10 10:38:07]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1678163002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1678163002/40001

[commit-bot: I haz the power, 2016-02-10 11:23:17]

Description was changed from

==========
mac_views_browser: fixed interactive_ui_tests compilation.

Splitting interactive_test_utils_mac.mm to
mac specific part - interactive_test_utils_mac.mm
and cocoa-views part - interactive_test_utils_cocoa.mm.

Splitting interactive_test_utils_views.cc to
interactive_test_utils_common_views.cc that can be used in mac tests
and interactive_test_utils_views.cc that used only in toolkit-views tests.

Disabled 3 tests files that are not ready for mac_views.

BUG=575036
COLLABORATOR=kirr@yandex-team.ru
Also reviewed in http://crrev.com/1669793002/
==========

to

==========
mac_views_browser: fixed interactive_ui_tests compilation.

Splitting interactive_test_utils_mac.mm to
mac specific part - interactive_test_utils_mac.mm
and cocoa-views part - interactive_test_utils_cocoa.mm.

Splitting interactive_test_utils_views.cc to
interactive_test_utils_common_views.cc that can be used in mac tests
and interactive_test_utils_views.cc that used only in toolkit-views tests.

Disabled 3 tests files that are not ready for mac_views.

BUG=575036
COLLABORATOR=kirr@yandex-team.ru
Also reviewed in http://crrev.com/1669793002/
==========

[commit-bot: I haz the power, 2016-02-10 11:23:17]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-02-10 11:24:11]

Description was changed from

==========
mac_views_browser: fixed interactive_ui_tests compilation.

Splitting interactive_test_utils_mac.mm to
mac specific part - interactive_test_utils_mac.mm
and cocoa-views part - interactive_test_utils_cocoa.mm.

Splitting interactive_test_utils_views.cc to
interactive_test_utils_common_views.cc that can be used in mac tests
and interactive_test_utils_views.cc that used only in toolkit-views tests.

Disabled 3 tests files that are not ready for mac_views.

BUG=575036
COLLABORATOR=kirr@yandex-team.ru
Also reviewed in http://crrev.com/1669793002/
==========

to

==========
mac_views_browser: fixed interactive_ui_tests compilation.

Splitting interactive_test_utils_mac.mm to
mac specific part - interactive_test_utils_mac.mm
and cocoa-views part - interactive_test_utils_cocoa.mm.

Splitting interactive_test_utils_views.cc to
interactive_test_utils_common_views.cc that can be used in mac tests
and interactive_test_utils_views.cc that used only in toolkit-views tests.

Disabled 3 tests files that are not ready for mac_views.

BUG=575036
COLLABORATOR=kirr@yandex-team.ru
Also reviewed in http://crrev.com/1669793002/

Committed: https://crrev.com/21b504032d9dcf75db5048eb48ef50204ae45b90
Cr-Commit-Position: refs/heads/master@{#374640}
==========

[commit-bot: I haz the power, 2016-02-10 11:24:12]

Patchset 3 (id:??) landed as
https://crrev.com/21b504032d9dcf75db5048eb48ef50204ae45b90
Cr-Commit-Position: refs/heads/master@{#374640}