Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4938)

Unified Diff: chrome/chrome_tests.gypi

Issue 1678163002: mac_views_browser: fixed interactive_ui_tests compilation. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Removed unneeded header, enable ActivateOverflowedToolbarActionWithKeyboard test compilation on Mac Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/views/toolbar/toolbar_view_interactive_uitest.cc ('k') | chrome/test/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/chrome_tests.gypi
diff --git a/chrome/chrome_tests.gypi b/chrome/chrome_tests.gypi
index a2a6e3057adddccc7070d01c477342e2b912c555..0cf9db8ece9a0e382939da75e4938efcf6682179 100644
--- a/chrome/chrome_tests.gypi
+++ b/chrome/chrome_tests.gypi
@@ -1050,9 +1050,7 @@
'browser/ui/browser_focus_uitest.cc',
'browser/ui/cocoa/apps/app_shim_menu_controller_mac_interactive_uitest.mm',
'browser/ui/cocoa/apps/quit_with_apps_controller_mac_interactive_uitest.mm',
- 'browser/ui/cocoa/extensions/browser_action_button_interactive_uitest.mm',
'browser/ui/cocoa/panels/panel_cocoa_browsertest.mm',
- 'browser/ui/cocoa/translate/translate_bubble_test_utils_cocoa.mm',
'browser/ui/exclusive_access/flash_fullscreen_interactive_browsertest.cc',
'browser/ui/exclusive_access/fullscreen_controller_interactive_browsertest.cc',
'browser/ui/exclusive_access/fullscreen_controller_state_interactive_browsertest.cc',
@@ -1087,7 +1085,7 @@
'test/base/interactive_test_utils_aura.cc',
'test/base/interactive_test_utils_aura.h',
'test/base/interactive_test_utils_mac.mm',
- 'test/base/interactive_test_utils_views.cc',
+ 'test/base/interactive_test_utils_common_views.cc',
'test/base/interactive_test_utils_win.cc',
'test/base/interactive_ui_tests_main.cc',
'test/base/view_event_test_platform_part.h',
@@ -1121,6 +1119,12 @@
'test/base/view_event_test_base.cc',
'test/base/view_event_test_base.h',
],
+ # Mac sources, except when mac_views_browser==1.
+ 'chrome_interactive_ui_test_cocoa_sources': [
+ 'browser/ui/cocoa/extensions/browser_action_button_interactive_uitest.mm',
+ 'browser/ui/cocoa/translate/translate_bubble_test_utils_cocoa.mm',
+ 'test/base/interactive_test_utils_cocoa.mm',
+ ],
'chrome_interactive_ui_test_app_list_sources': [
'browser/ui/app_list/app_list_service_interactive_uitest.cc',
'browser/ui/app_list/app_list_service_mac_interactive_uitest.mm',
@@ -1165,6 +1169,7 @@
'browser/ui/views/toolbar/toolbar_action_view_interactive_uitest.cc',
'browser/ui/views/toolbar/toolbar_view_interactive_uitest.cc',
'browser/ui/views/translate/translate_bubble_test_utils_views.cc',
+ 'test/base/interactive_test_utils_views.cc',
],
'chrome_interactive_ui_test_notifications_sources': [
'browser/extensions/api/notifications/notifications_apitest.cc',
@@ -1715,6 +1720,20 @@
],
# See comment about the same line in chrome/chrome_tests.gypi.
'xcode_settings': {'OTHER_LDFLAGS': ['-Wl,-ObjC']},
+ 'conditions' : [
+ # The browser window can be views or Cocoa on Mac. Test accordingly.
+ ['mac_views_browser==1', {
+ 'sources': [ '<@(chrome_interactive_ui_test_views_non_mac_sources)' ],
+ # Following tests needs a refactoring to works with mac_views.
+ 'sources!': [
+ # Aura depended tests.
+ 'browser/ui/views/bookmarks/bookmark_bar_view_test.cc',
+ 'browser/ui/views/tabs/tab_drag_controller_interactive_uitest.cc',
+ ]
+ }, {
+ 'sources': [ '<@(chrome_interactive_ui_test_cocoa_sources)' ],
+ }], # mac_views_browser==1
+ ],
}, { # Non-Mac.
'sources': [ '<@(chrome_interactive_ui_test_views_non_mac_sources)' ],
}],
« no previous file with comments | « chrome/browser/ui/views/toolbar/toolbar_view_interactive_uitest.cc ('k') | chrome/test/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698