Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(563)

Issue 1678063002: Fix usage of deprecated function CFPropertyListCreateFromXMLData. (Closed)

Created:
4 years, 10 months ago by sdefresne
Modified:
4 years, 10 months ago
Reviewers:
Mark Mentovai
CC:
google-breakpad-dev_googlegroups.com
Base URL:
https://chromium.googlesource.com/breakpad/breakpad.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix usage of deprecated function CFPropertyListCreateFromXMLData. The function CFPropertyListCreateFromXMLData is deprecated in favor of the function CFPropertyListCreateWithData that is available since the 10.6 OS X SDK and 4.0 iOS SDK. BUG=https://bugs.chromium.org/p/google-breakpad/issues/detail?id=675 BUG=569158 R=mark@chromium.org Committed: https://chromium.googlesource.com/breakpad/breakpad/+/cd891cd1ed96f4feafbacc8f2dab2bd8577f8649

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M src/client/mac/handler/minidump_generator.cc View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
sdefresne
Please take a look. This is a partial reland of https://codereview.chromium.org/1563223004/ (the changes in src/common/mac/HTTPMultipartUpload.m ...
4 years, 10 months ago (2016-02-08 11:05:29 UTC) #2
Mark Mentovai
LGTM
4 years, 10 months ago (2016-02-08 15:07:18 UTC) #3
sdefresne
4 years, 10 months ago (2016-02-08 16:38:39 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
cd891cd1ed96f4feafbacc8f2dab2bd8577f8649 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698