Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(159)

Issue 1677803002: Add a bunch of NSS ASN.1 fuzzers (Closed)

Created:
4 years, 10 months ago by Ryan Sleevi
Modified:
3 years, 9 months ago
Reviewers:
mmoroz, kcc2, aizatsky
CC:
chromium-reviews, inferno
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add a bunch of NSS ASN.1 fuzzers BUG=none

Patch Set 1 #

Patch Set 2 : Compile fixes #

Patch Set 3 : AlgorithmID fix #

Patch Set 4 : Don't free algorithms when in an arena (Bad NSS API #231) #

Patch Set 5 : Compile fix for algorithmid (-Wunused-variable) #

Patch Set 6 : Wow I'm bad #

Patch Set 7 : Stop zeroing our stuff #

Total comments: 2

Patch Set 8 : Rebased #

Patch Set 9 : Common template #

Patch Set 10 : Fix leak #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+300 lines, -42 lines) Patch
M BUILD.gn View 1 2 3 4 5 6 7 1 chunk +1 line, -0 lines 0 comments Download
A testing/libfuzzer/fuzzers/nss/BUILD.gn View 1 1 chunk +149 lines, -0 lines 1 comment Download
A + testing/libfuzzer/fuzzers/nss/asn1_algorithmid_fuzzer.cc View 1 2 3 4 5 6 7 8 1 chunk +7 lines, -3 lines 0 comments Download
A + testing/libfuzzer/fuzzers/nss/asn1_any_fuzzer.cc View 1 2 3 4 5 6 7 8 1 chunk +6 lines, -3 lines 0 comments Download
A + testing/libfuzzer/fuzzers/nss/asn1_bitstring_fuzzer.cc View 1 2 3 4 5 6 7 8 1 chunk +6 lines, -3 lines 0 comments Download
A + testing/libfuzzer/fuzzers/nss/asn1_bmpstring_fuzzer.cc View 1 2 3 4 5 6 7 8 1 chunk +6 lines, -3 lines 0 comments Download
A + testing/libfuzzer/fuzzers/nss/asn1_boolean_fuzzer.cc View 1 2 3 4 5 6 7 8 1 chunk +6 lines, -3 lines 0 comments Download
A testing/libfuzzer/fuzzers/nss/asn1_fuzzer_template.h View 1 2 3 4 5 6 7 8 9 1 chunk +45 lines, -0 lines 0 comments Download
A + testing/libfuzzer/fuzzers/nss/asn1_generalizedtime_fuzzer.cc View 1 2 3 4 5 6 7 8 1 chunk +6 lines, -3 lines 0 comments Download
A + testing/libfuzzer/fuzzers/nss/asn1_ia5string_fuzzer.cc View 1 2 3 4 5 6 7 8 1 chunk +6 lines, -3 lines 0 comments Download
A + testing/libfuzzer/fuzzers/nss/asn1_integer_fuzzer.cc View 1 2 3 4 5 6 7 8 1 chunk +6 lines, -3 lines 0 comments Download
A + testing/libfuzzer/fuzzers/nss/asn1_null_fuzzer.cc View 1 2 3 4 5 6 7 8 1 chunk +6 lines, -3 lines 0 comments Download
A + testing/libfuzzer/fuzzers/nss/asn1_objectid_fuzzer.cc View 1 2 3 4 5 6 7 8 1 chunk +6 lines, -3 lines 0 comments Download
A + testing/libfuzzer/fuzzers/nss/asn1_octetstring_fuzzer.cc View 1 2 3 4 5 6 7 8 1 chunk +6 lines, -3 lines 0 comments Download
A + testing/libfuzzer/fuzzers/nss/asn1_utctime_fuzzer.cc View 1 2 3 4 5 6 7 8 1 chunk +6 lines, -3 lines 0 comments Download
A + testing/libfuzzer/fuzzers/nss/asn1_utf8string_fuzzer.cc View 1 2 3 4 5 6 7 8 1 chunk +6 lines, -3 lines 0 comments Download
A + testing/libfuzzer/fuzzers/nss/cert_certificate_fuzzer.cc View 1 2 3 4 5 6 7 8 1 chunk +7 lines, -3 lines 0 comments Download
A testing/libfuzzer/fuzzers/nss/seckey_privatekeyinfo_fuzzer.cc View 1 2 3 4 5 6 7 8 1 chunk +19 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (4 generated)
kcc2
Cool! While we are figuring out where to get instrumented libnss & friends, I'd like ...
4 years, 10 months ago (2016-02-06 05:36:03 UTC) #2
kcc2
On 2016/02/06 05:36:03, kcc2 wrote: > Cool! > While we are figuring out where to ...
4 years, 10 months ago (2016-02-06 05:37:39 UTC) #3
Ryan Sleevi
All should be compiling now :) There is a BUILD.gn for NSS, but it was ...
4 years, 10 months ago (2016-02-08 00:01:17 UTC) #4
Ryan Sleevi
kcc: This is ready for your review
4 years, 10 months ago (2016-02-10 00:30:56 UTC) #5
kcc2
On 2016/02/10 00:30:56, Ryan Sleevi wrote: > kcc: This is ready for your review question ...
4 years, 10 months ago (2016-02-10 00:46:06 UTC) #6
Ryan Sleevi
On 2016/02/10 00:46:06, kcc2 wrote: > On 2016/02/10 00:30:56, Ryan Sleevi wrote: > > kcc: ...
4 years, 10 months ago (2016-02-10 00:50:10 UTC) #7
kcc2
https://codereview.chromium.org/1677803002/diff/120001/testing/libfuzzer/fuzzers/nss/asn1_bitstring_fuzzer.cc File testing/libfuzzer/fuzzers/nss/asn1_bitstring_fuzzer.cc (right): https://codereview.chromium.org/1677803002/diff/120001/testing/libfuzzer/fuzzers/nss/asn1_bitstring_fuzzer.cc#newcode20 testing/libfuzzer/fuzzers/nss/asn1_bitstring_fuzzer.cc:20: // Attempt the QuickDER path. does this have to ...
4 years, 10 months ago (2016-02-10 02:25:23 UTC) #8
Ryan Sleevi
https://codereview.chromium.org/1677803002/diff/120001/testing/libfuzzer/fuzzers/nss/asn1_bitstring_fuzzer.cc File testing/libfuzzer/fuzzers/nss/asn1_bitstring_fuzzer.cc (right): https://codereview.chromium.org/1677803002/diff/120001/testing/libfuzzer/fuzzers/nss/asn1_bitstring_fuzzer.cc#newcode20 testing/libfuzzer/fuzzers/nss/asn1_bitstring_fuzzer.cc:20: // Attempt the QuickDER path. On 2016/02/10 02:25:22, kcc2 ...
4 years, 10 months ago (2016-02-10 02:45:36 UTC) #9
kcc2
> Templated logic is totally fine, right? Yes, templates would be welcome here. From an ...
4 years, 10 months ago (2016-02-11 05:28:20 UTC) #12
Ryan Sleevi
Upstream bugs: NSS: - https://bugzilla.mozilla.org/show_bug.cgi?id=1253101 - https://bugzilla.mozilla.org/show_bug.cgi?id=1253107 NSPR: - https://bugzilla.mozilla.org/show_bug.cgi?id=1253105 1253101 is the necessary one ...
4 years, 9 months ago (2016-03-03 02:21:19 UTC) #13
mmoroz
https://codereview.chromium.org/1677803002/diff/180001/testing/libfuzzer/fuzzers/nss/BUILD.gn File testing/libfuzzer/fuzzers/nss/BUILD.gn (right): https://codereview.chromium.org/1677803002/diff/180001/testing/libfuzzer/fuzzers/nss/BUILD.gn#newcode15 testing/libfuzzer/fuzzers/nss/BUILD.gn:15: fuzzer_test("asn1_algorithmid_fuzzer") { Do you mind do add "nss_" prefix ...
4 years, 9 months ago (2016-03-03 10:28:33 UTC) #15
mmoroz
4 years, 1 month ago (2016-11-07 13:54:32 UTC) #16
YI, we are running these fuzzers using oss-fuzz project infrastructure:
https://github.com/google/oss-fuzz/tree/master/targets/nss

Any improvements are more than welcome :)

Powered by Google App Engine
This is Rietveld 408576698