Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(283)

Issue 1677783002: Fix multiscript tests. Code merged for 45 was accidentally crashing the render process when V8 thre… (Closed)

Created:
4 years, 10 months ago by Jacob
Modified:
4 years, 10 months ago
Reviewers:
Alan Knight
CC:
reviews+dom_dartlang.org, terry
Target Ref:
refs/remotes/git-svn
Project:
blink
Visibility:
Public.

Description

Fix multiscript tests. Code merged for 45 was accidentally crashing the render process when V8 threw an exception instead of just throwing an exception. BUG= Committed: https://src.chromium.org/viewvc/blink/branches/dart/dartium?view=rev&revision=202772

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -13 lines) Patch
M Source/bindings/core/dart/DartJsInterop.cpp View 3 chunks +28 lines, -13 lines 0 comments Download

Messages

Total messages: 4 (2 generated)
Jacob
TBR. This fixes all crashing layout tests and likely explains a lot of crashing dartium ...
4 years, 10 months ago (2016-02-05 23:33:34 UTC) #2
Jacob
4 years, 10 months ago (2016-02-05 23:34:14 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 202772 (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698