Fix multiscript tests. Code merged for 45 was accidentally crashing the render process when V8 thre…

Source/bindings/core/dart/DartJsInterop.cpp

 /*
  * Copyright (C) 2013 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 960 matching lines @@
 
         Vector<v8::Local<v8::Value> > v8Args;
         argsListToV8(domData, Dart_GetNativeArgument(args, 2), &v8Args, exception);
         if (exception)
             goto fail;
         if (!Dart_IsString(name))
             name = Dart_ToString(name);
 
         v8::Local<v8::Value> value = v8Receiver->Get(V8Converter::stringToV8(name));
         v8::Local<v8::Value> ret;
+
         if (value->IsFunction()) {
-            ret = V8ScriptRunner::callFunction(value.As<v8::Function>(), DartUtilities::scriptExecutionContext(), receiver->localV8Object(), v8Args.size(), v8Args.data(), v8::Isolate::GetCurrent()).ToLocalChecked();
+
+            v8::Local<v8::Value> result;
+            if (!V8ScriptRunner::callFunction(value.As<v8::Function>(),
+                DartUtilities::scriptExecutionContext(), receiver->localV8Object(), v8Args.size(), v8Args.data(), v8::Isolate::GetCurrent()).ToLocal(&ret)) {
+                exception = Dart_NewStringFromCString("V8 Exception");
+                goto fail;
+            }
         } else {
             // FIXME: we currently convert this exception to a NoSuchMethod
             // exception in the Dart code that wraps this native method.
             // Consider throwing a NoSuchMethod exception directly instead.
             exception = Dart_NewStringFromCString("property is not a function");
             goto fail;
         }
 
         if (scopes.handleJsException(&exception))
             goto fail;
@@ skipping 113 matching lines @@
         } else {
             thisArg = JsInterop::fromDart(domData, thisArgDart, exception);
             if (exception)
                 goto fail;
             if (!thisArg->IsObject()) {
                 exception = Dart_NewStringFromCString("thisArg is not an object");
                 goto fail;
             }
         }
 
-        v8::Local<v8::Value> ret = V8ScriptRunner::callFunction(receiver->localV8Function(),
-            DartUtilities::scriptExecutionContext(),
-            thisArg.As<v8::Object>(),
-            v8Args.size(),
-            v8Args.data(),
-            v8::Isolate::GetCurrent()).ToLocalChecked();
+        v8::Local<v8::Value> ret;
+        if (!V8ScriptRunner::callFunction(receiver->localV8Function(),
+                DartUtilities::scriptExecutionContext(),
+                thisArg.As<v8::Object>(),
+                v8Args.size(),
+                v8Args.data(),
+                v8::Isolate::GetCurrent()).ToLocal(&ret)) {
+            exception = Dart_NewStringFromCString("V8 Exception");
+            goto fail;
+        }
         if (scopes.handleJsException(&exception))
             goto fail;
         scopes.setReturnValue(ret);
         return;
     }
 
 fail:
     Dart_ThrowException(exception);
     ASSERT_NOT_REACHED();
 }
@@ skipping 19 matching lines @@
         } else {
             thisArg = JsInterop::fromDart(domData, thisArgDart, exception);
             if (exception)
                 goto fail;
             if (!thisArg->IsObject()) {
                 exception = Dart_NewStringFromCString("thisArg is not an object");
                 goto fail;
             }
         }
 
-        v8::Local<v8::Value> ret = V8ScriptRunner::callFunction(receiver->localV8Function(),
-            DartUtilities::scriptExecutionContext(),
-            thisArg.As<v8::Object>(),
-            v8Args.size(),
-            v8Args.data(),
-            v8::Isolate::GetCurrent()).ToLocalChecked();
+        v8::Local<v8::Value> ret;
+        if (!V8ScriptRunner::callFunction(receiver->localV8Function(),
+                DartUtilities::scriptExecutionContext(),
+                thisArg.As<v8::Object>(),
+                v8Args.size(),
+                v8Args.data(),
+                v8::Isolate::GetCurrent()).ToLocal(&ret)) {
+            exception = Dart_NewStringFromCString("V8 Exception");
+            goto fail;
+        }
         if (scopes.handleJsException(&exception))
             goto fail;
         scopes.setReturnValue(ret);
         return;
     }
 
 fail:
     Dart_ThrowException(exception);
     ASSERT_NOT_REACHED();
 }
@@ skipping 627 matching lines @@
 {
     JsInteropInternal::callMethodCallback(args);
 }
 
 void JsInterop::jsInteropContextCallback(Dart_NativeArguments args)
 {
     return JsInteropInternal::contextCallback(args);
 }
 
 }