Issue 167753003: cc: Added modifier string to clarify perf tests.

Issue 167753003: cc: Added modifier string to clarify perf tests. (Closed)

Created:
6 years, 10 months ago by alokp

Modified:
6 years, 10 months ago

Reviewers:
reveman

CC:
chromium-reviews, cc-bugs_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

cc: Added modifier string to clarify perf tests. A few perf tests were writing results against the same measurement name making it impossible to distinguish and compare measurements. This patch adds modifier strings to make the measurments clear. BUG=343684 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=252118

Patch Set 1 #

Patch Set 2 : re-upload #

Total comments: 4

Patch Set 3 : addressed comments #

Patch Set 4 : rebase #

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+29 lines, -8 lines)			Patch
	M	cc/resources/raster_worker_pool_perftest.cc	View	1 2 3	4 chunks	+16 lines, -3 lines	0 comments	Download
	M	cc/resources/task_graph_runner_perftest.cc	View	1 2	4 chunks	+13 lines, -5 lines	0 comments	Download

Messages

Total messages: 10 (0 generated)

Expand Messages | Collapse Messages

reveman

Thanks! lgtm after updating the switch statement. https://codereview.chromium.org/167753003/diff/50001/cc/resources/raster_worker_pool_perftest.cc File cc/resources/raster_worker_pool_perftest.cc (right): https://codereview.chromium.org/167753003/diff/50001/cc/resources/raster_worker_pool_perftest.cc#newcode345 cc/resources/raster_worker_pool_perftest.cc:345: default: Please ...

6 years, 10 months ago (2014-02-14 23:40:16 UTC) #2

alokp

https://codereview.chromium.org/167753003/diff/50001/cc/resources/raster_worker_pool_perftest.cc File cc/resources/raster_worker_pool_perftest.cc (right): https://codereview.chromium.org/167753003/diff/50001/cc/resources/raster_worker_pool_perftest.cc#newcode345 cc/resources/raster_worker_pool_perftest.cc:345: default: On 2014/02/14 23:40:16, David Reveman wrote: > Please ...

6 years, 10 months ago (2014-02-15 00:26:11 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/alokp@chromium.org/167753003/110001

6 years, 10 months ago (2014-02-15 00:38:40 UTC) #5

commit-bot: I haz the power

The CQ bit was unchecked by commit-bot@chromium.org

6 years, 10 months ago (2014-02-15 02:39:13 UTC) #6

commit-bot: I haz the power

Retried try job too often on android_aosp for step(s) compile http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_aosp&number=48385

6 years, 10 months ago (2014-02-15 02:39:13 UTC) #7

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/alokp@chromium.org/167753003/370001

6 years, 10 months ago (2014-02-19 18:52:03 UTC) #9

Message was sent while issue was closed.

Change committed as 252118

Expand Messages | Collapse Messages